Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
77e3591
feat: Autofix Core APIs (base)
maxreichmann Apr 24, 2025
02f02ad
refactor: Remove redundant functionality
d3xter666 May 28, 2025
4c11ac2
refactor: Test cases
d3xter666 May 28, 2025
491b749
refactor: Cleanups
d3xter666 May 28, 2025
46feda3
refactor: Remove redundant code
d3xter666 May 28, 2025
1c44907
fix: Resolve merge conflicts
d3xter666 May 28, 2025
fdddf58
refactor: Remove redundant tests
d3xter666 May 29, 2025
0698e8c
refactor: Reuse Ui5TypeInfo for module detection
d3xter666 May 29, 2025
e6144e5
fix: Type info
d3xter666 May 29, 2025
c340dce
fix: Check for Core api refactored
d3xter666 May 30, 2025
0a9edc4
fix: Cleanup redundant code
d3xter666 May 30, 2025
fbade08
refactor: Reuse ui5TypeInfo instead of resolving namespace manually
d3xter666 May 30, 2025
349a614
refactor: Use only module from UI5Type
d3xter666 May 30, 2025
3c915c4
refactor: Improve samples
d3xter666 May 30, 2025
a03416e
test: Leave only migrated cases in tests
d3xter666 May 30, 2025
ffa2981
feat: Autofix Core APIs (base)
maxreichmann Apr 24, 2025
dafade5
fix: Merge conflicts
d3xter666 May 27, 2025
ef688bd
feat: Add a map with the Core fixHints
d3xter666 May 15, 2025
18732fa
refactor: Extract namespace resolver into util
d3xter666 May 16, 2025
abc4472
refactor: Reuse extractNamespace
d3xter666 May 16, 2025
f4f71ed
refactor: Renames of variable names
d3xter666 May 19, 2025
da9b6bf
feat: Enable exportCodeToBeUsed
d3xter666 May 19, 2025
75cc45a
feat: Migrate applyTheme
d3xter666 May 19, 2025
24bf00c
fix: Enable/disable/postpone certain cases
d3xter666 May 19, 2025
0c422bd
feat: Enable getComponent migration
d3xter666 May 19, 2025
f373632
feat: Enable loadLibrary migration
d3xter666 May 20, 2025
20fff97
feat: Enable createComponent migration
d3xter666 May 20, 2025
1cbaa2c
feat: Enable getLibraryResourceBundle migration
d3xter666 May 20, 2025
73fc71d
feat: Detect libs from manifest.json
d3xter666 May 27, 2025
fa9373f
feat: Detect lib namespace
d3xter666 May 27, 2025
4be6674
fix: Use modules, not globals
d3xter666 May 27, 2025
2915da4
test: Update snapshots
d3xter666 May 27, 2025
142971a
fix: Resolve merge conflicts
d3xter666 May 27, 2025
0685812
fix: Rebase conflicts
d3xter666 May 28, 2025
8133d7d
refactor: Cleanups
d3xter666 May 28, 2025
703d5ab
refactor: Remove redundant code
d3xter666 May 28, 2025
d359488
fix: Update snapshots
d3xter666 May 28, 2025
9866bb3
test: Remove redundant code
d3xter666 May 28, 2025
3e4839c
test: Update snapshots
d3xter666 May 28, 2025
d30b3c2
fix: Resolve merge conflicts
d3xter666 May 28, 2025
6ee3cc7
fix: Resolve value of getActiveElement()
d3xter666 May 29, 2025
4500d09
refactor: Postpone migration of loadLibrary & createComponent
d3xter666 May 29, 2025
770c39b
test: Remove not migrated test cases
d3xter666 May 30, 2025
c5aff91
test: Update snapshots
d3xter666 May 27, 2025
1c0bd9f
feat: Autofix Core APIs (base)
maxreichmann Apr 24, 2025
cb5bb6f
feat: Determine library resource
d3xter666 May 28, 2025
599638c
fix: Correctly provide manifest for autofixer
d3xter666 May 28, 2025
7b33eaf
fix: Manifest content
d3xter666 May 28, 2025
eea6ea8
fix: Merge conflicts
d3xter666 May 28, 2025
a4f0c7b
fix: Resolve merge conflicts
d3xter666 May 29, 2025
1b6889a
fix: Resolve merge conflicts
d3xter666 May 29, 2025
d3a04e0
test: Update snapshots
d3xter666 May 29, 2025
369f843
refactor: Tests
d3xter666 May 30, 2025
d4a3439
refactor: Align code with the major refactoring
d3xter666 Jun 12, 2025
0688c57
refactor: Migrate attachIntervalTimer
d3xter666 Jun 12, 2025
a0e6637
refactor: Enable migration of loadLibrary
d3xter666 Jun 12, 2025
3dd7068
refactor: Enable createComponent
d3xter666 Jun 12, 2025
0cbc2b8
refactor: Enable getLibraryResourceBundle scenarios
d3xter666 Jun 12, 2025
3a432fc
refactor: Cleanups
d3xter666 Jun 12, 2025
7b73620
test: Enable scenarios
d3xter666 Jun 12, 2025
a7087f3
fix: Merge issues
d3xter666 Jun 17, 2025
4a10a40
test: Update snapshots
d3xter666 Jun 17, 2025
e651679
refactor: Check libraries in manifest
d3xter666 Jun 17, 2025
5ffc24c
test: Update snapshots
d3xter666 Jun 17, 2025
f048575
refactor: Enable lib checks for getLibraryResourceBundle
d3xter666 Jun 17, 2025
e3b522a
fix: Merge conflicts
d3xter666 Jun 18, 2025
3a53ec1
refactor: Cleanup code
d3xter666 Jun 19, 2025
4e5b615
refactor: Improve loadLibrary fixture
d3xter666 Jun 19, 2025
113a056
refactor: Improve loadLibrary replacements
d3xter666 Jun 19, 2025
1491b3c
refactor: Support shorthand for loadLibrary
d3xter666 Jun 19, 2025
8baa6fc
refactor: Do not allowlist for props in args of loadLibrary
d3xter666 Jun 19, 2025
f8decda
fix: Merge conflicts
d3xter666 Jun 19, 2025
c84f3e0
refactor: Shorthand prop assignments for createComponent
d3xter666 Jun 19, 2025
6610681
fix: Properly resolve JSON for Component.create
d3xter666 Jun 19, 2025
1fc5eed
fix: Get the real node in shorthandProperty assignment
d3xter666 Jun 20, 2025
4540021
refactor: Reuse directly resolved libraryDependencies in arguments va…
d3xter666 Jun 20, 2025
6cb8992
fix: ESLint issues
d3xter666 Jun 20, 2025
deb2ddc
refactor: Correct arg name
d3xter666 Jun 20, 2025
c52ac69
refactor: Revert manifest code
d3xter666 Jun 20, 2025
acd8198
fix: Resolve name
d3xter666 Jun 20, 2025
d3474ea
test: Provide alternative sample for undefined in getLibraryResourceB…
d3xter666 Jun 20, 2025
8e43420
fix: Merge conflicts
d3xter666 Jun 20, 2025
1725d7d
refactor: Remove redundant check
d3xter666 Jun 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/linter/ui5Types/SourceFileLinter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import {
import FixFactory from "./fix/FixFactory.js";
import Fix, {FixHelpers} from "./fix/Fix.js";
import GlobalFix from "./fix/GlobalFix.js";
import {JSONSchemaForSAPUI5Namespace} from "../../manifest.js";

const log = getLogger("linter:ui5Types:SourceFileLinter");

Expand Down Expand Up @@ -93,7 +94,8 @@ export default class SourceFileLinter {
private workspace: AbstractAdapter,
private ambientModuleCache: AmbientModuleCache,
private fixFactory?: FixFactory,
private manifestContent?: string
private manifestContent?: string,
private libraryDependencies?: JSONSchemaForSAPUI5Namespace["dependencies"]["libs"]
) {
this.#reporter = typeLinter.getSourceFileReporter(sourceFile);
this.#boundVisitNode = this.visitNode.bind(this);
Expand All @@ -106,6 +108,7 @@ export default class SourceFileLinter {
this.fixHelpers = {
checker: this.checker,
manifestContent: this.manifestContent,
libraryDependencies: this.libraryDependencies,
};
}

Expand Down
2 changes: 1 addition & 1 deletion src/linter/ui5Types/TypeLinter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export default class TypeLinter {
sourceFile,
checker, reportCoverage, messageDetails,
apiExtract, this.#filePathsWorkspace, this.#workspace, ambientModuleCache,
fixFactory, manifestContent
fixFactory, manifestContent, this.#libraryDependencies
);
await linter.lint();
linterDone();
Expand Down
2 changes: 2 additions & 0 deletions src/linter/ui5Types/fix/Fix.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import ts from "typescript";
import {PositionInfo} from "../../LinterContext.js";
import {ChangeSet} from "../../../autofix/autofix.js";
import {SaxEventType} from "sax-wasm";
import {JSONSchemaForSAPUI5Namespace} from "../../../manifest.js";

export interface ModuleDependencyRequest {
moduleName: string;
Expand Down Expand Up @@ -29,6 +30,7 @@ export interface NodeSearchParameters {
export interface FixHelpers {
checker: ts.TypeChecker;
manifestContent?: string;
libraryDependencies: JSONSchemaForSAPUI5Namespace["dependencies"]["libs"];
}

export default abstract class Fix {
Expand Down
Loading