Skip to content

fix(builder): Update lbt/bundle/Resolver to ensure deterministic ordering of raw modules#1375

Merged
RandomByte merged 1 commit into
mainfrom
lbt-fix-raw-module-order
May 8, 2026
Merged

fix(builder): Update lbt/bundle/Resolver to ensure deterministic ordering of raw modules#1375
RandomByte merged 1 commit into
mainfrom
lbt-fix-raw-module-order

Conversation

@RandomByte

@RandomByte RandomByte commented May 8, 2026

Copy link
Copy Markdown
Member

Upport of SAP/ui5-builder#1208

When multiple raw modules share a common dependency, the topological
sort tie-breaks by input order. Previously, the input order depended
on async resolution timing (pool insertion order), making the output
non-deterministic.

Now modules are sorted by their filter definition order before
topological sorting, ensuring that modules at the same dependency
level appear in the order defined by the section's filter list.

…ring of raw modules

When multiple raw modules share a common dependency, the topological
sort tie-breaks by input order. Previously, the input order depended
on async resolution timing (pool insertion order), making the output
non-deterministic.

Now modules are sorted by their filter definition order before
topological sorting, ensuring that modules at the same dependency
level appear in the order defined by the section's filter list.
@RandomByte RandomByte requested a review from matz3 May 8, 2026 15:11

@codeworrior codeworrior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the up-port! LGTM.

@RandomByte RandomByte merged commit 9d19923 into main May 8, 2026
30 checks passed
@RandomByte RandomByte deleted the lbt-fix-raw-module-order branch May 8, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants