fix(builder): Improve error ESM handling#1374
Merged
Merged
Conversation
RandomByte
changed the title
Change the log level for JS parse failures in determineDependencyInfo from error to verbose. These parse errors occur frequently when a library contains third-party ESM code (using import/export), which the LBT bundler does not support. Since these modules are typically not included in custom bundles, logging at error level creates unnecessary noise for users. Errors during actual bundling (e.g. writePreloadModule) are still reported at the appropriate level.
ESM modules (using import/export) cannot be bundled with the
LBT bundler. Previously, including an ESM module in a preload
section caused the bundle to contain a literal "undefined" string
due to rewriteDefine() returning {} instead of null on parse error.
- Add Format.ESM to ModuleInfo and detect ESM in ResourcePool
during dependency analysis
- Filter out ESM modules during bundle resolution in Resolver,
so they are excluded from all section types
- Exclude ESM modules from bundle subModule metadata
- Fix rewriteDefine() to return null on parse error (safety fix)
Modules using import.meta (e.g. import.meta.url, import.meta.resolve) were not detected as ESM because only the 'import'/'export' parse error was checked. Now also handle the 'Cannot use import.meta outside a module' error from espree.
RandomByte
force-pushed
the
lbt-improvements-upport
branch
from
b2992cf to
b312316
Compare
RandomByte
changed the title
matz3
changed the title
matz3
approved these changes
May 8, 2026
matz3
left a comment
matz3
left a comment
Member
There was a problem hiding this comment.
LGTM. I updated the PR title and commit messages in the PR body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up-port of SAP/ui5-builder#1203