feat: Trailing block extension rewrite#2733
Open
matthewlipski wants to merge 10 commits intomainfrom
Open
Conversation
…tead of actual node, udpated tests & examples
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 242 files, which is 92 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (33)
📒 Files selected for processing (242)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
reviewed
May 11, 2026
nperez0111
reviewed
May 11, 2026
nperez0111
reviewed
May 11, 2026
Comment on lines
+55
to
+67
| const blockContainerType = | ||
| view.state.schema.nodes["blockContainer"]; | ||
| const paragraphType = view.state.schema.nodes["paragraph"]; | ||
| const node = blockContainerType.create( | ||
| undefined, | ||
| paragraphType.create(), | ||
| ); | ||
| const insertPos = view.state.doc.content.size - 1; | ||
| const tr = view.state.tr.insert(insertPos, node); | ||
| tr.setSelection(TextSelection.create(tr.doc, insertPos + 2)); | ||
| tr.scrollIntoView(); | ||
| view.dispatch(tr); | ||
| view.focus(); |
Contributor
There was a problem hiding this comment.
why not blocknote apis for this?
nperez0111
reviewed
May 11, 2026
Comment on lines
+75
to
+97
| // Maps the existing DecorationSet through the transaction, then | ||
| // incrementally adds or removes the widget only if the show/hide state | ||
| // crossed over. The underlying Decoration (and its rendered DOM) stays | ||
| // reference-stable across transactions. | ||
| function nextDecorationSet( | ||
| tr: Transaction, | ||
| oldSet: DecorationSet, | ||
| ): DecorationSet { | ||
| const mapped = oldSet.map(tr.mapping, tr.doc); | ||
| const existing = mapped.find(); | ||
| const wasShowing = existing.length > 0; | ||
| const shouldShow = shouldShowTrailingWidget(tr.doc); | ||
|
|
||
| if (!lastContentNode) { | ||
| throw new Error("Expected blockContent"); | ||
| } | ||
| if (wasShowing === shouldShow) { | ||
| return mapped; | ||
| } | ||
| if (wasShowing) { | ||
| return mapped.remove(existing); | ||
| } | ||
| return mapped.add(tr.doc, [ | ||
| createTrailingWidget(tr.doc.content.size - 1), | ||
| ]); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
Changes
Impact
Testing
Screenshots/Video
Checklist
Additional Notes