feat: field of view slider#1991
Open
GiorgioMendieta wants to merge 4 commits into
Open
Conversation
Member
|
Looks good code-wise, but not a fan of how it jumps on scene changes. May want better logic for applying the FOV even during some events |
Contributor
Author
Yeah I've been trying to find out where the FOV changes on certain scenes but I just cannot find it. I was wondering if it would be acceptable to merge this PR for now and then later implement the fix in another PR ? |
Collaborator
|
We'd rather have it fully working without any bugs before merging. |
- game over event camera - dig hole event camera
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a Field of View slider from 45º to 90º (default is 60º). Defaults to 60º for speedrunning mode.
FOV is not affected during events or cutscenes.
I think this might introduce some visual glitches at high values due to the nature of the change, some testing is welcome.
compressed_8MB_Screen.Recording.2026-06-04.at.18.33.04.mp4
Closes #1462