feat: Make gamepad status lighting optional#1705
Merged
encounter merged 12 commits intoMay 28, 2026
Merged
Conversation
Collaborator
|
Maybe rename it to "Enable Controller LED" ? Sounds easier to understand |
Contributor
Author
Done |
Contributor
|
Does this option only show when a LED is detected? |
Contributor
Author
No, I could add that tho. |
Collaborator
Make sure it shows up and not when plugging in/out the controller. |
Contributor
Author
|
converted to draft until relevant PR in Aurora is merged and dusklight is updated. |
encounter
reviewed
May 24, 2026
# Conflicts: # extern/aurora # include/dusk/settings.h # src/dusk/settings.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates an option for enabling/disabling the gamepad status lighting. The default is true, to not change behavior. But it allows a user to disable the option, should they wish to change the gamepad's lighting or turn it off entirely.