refactor: Separate Vault economy into Legacy and VaultUnlocked implementations.#73
Open
awdrgyj8 wants to merge 1 commit into
Open
refactor: Separate Vault economy into Legacy and VaultUnlocked implementations.#73awdrgyj8 wants to merge 1 commit into
awdrgyj8 wants to merge 1 commit into
Conversation
…entations Introduce `LegacyVaultEconomy` for single-currency Vault providers and `VaultUnlockedEconomy` for multi-currency configurations. Streamline `VaultEconomy` to dynamically delegate to the appropriate implementation. Update Lombok dependency to 1.18.40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just wanted to apologize for the earlier Vault support PR.
After looking into it more carefully, I realized my original implementation made some wrong assumptions around legacy Vault vs VaultUnlocked multi-currency support. Sorry for the extra review and follow-up work that caused after you had already merged it.
I refactored the support so legacy Vault and VaultUnlocked are handled separately now, and I’ve tested the updated implementation on my end without any issues. This should make the behavior clearer and safer. Thanks again for taking the time to review and merge the PR.