SamuelLouf/Geolocation: mark as not supported in desktop app#2564
Merged
Conversation
github-actions
Bot
added
the
pr: change existing extension
Member
Author
|
!format |
Member
Author
|
It was already disabled in the desktop app via security manager: https://github.com/TurboWarp/desktop/blob/f0b8f21854222e889c8d7931b5e024d032464f37/src-renderer-webpack/editor/gui/desktop-hoc.jsx#L73 And the desktop app's permission checks deny all unneeded permissions, such as location. This change makes it properly report as not supported at all (not just not allowed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Electron, the geolocation APIs don't work unless we provide a GOOGLE_API_KEY with billing enabled for Google to charge per request. This key has to be embedded in plain text in every copy of the desktop app too, so it's public and anyone could start putting a lot of usage on it overnight. Don't really want to fund that, so it's just not going to work there. That'll include the desktop app and packaged Electron projects.
For the desktop app, making this work on macOS would also probably require the location services entitlement. I don't really want to try explaining to App Store Review why the app needs location services without having some good explanation of what people are doing with this thing.