utilities: Fix boolean casting in string to boolean block#2558
Merged
Conversation
github-actions
Bot
added
the
pr: change existing extension
Brackets-Coder
approved these changes
Jul 3, 2026
Contributor
|
The only concerns i might have are the rare occasions where a project might rely on this not returning a boolean, but I significantly doubt that since the block is a boolean anyway and that's what most users would expect to be returned |
Collaborator
Author
|
Relying on a bug for a coupler block that goes into Boolean slots. If someone is using this for another behaviour (which is incorrect) than that's on them. |
Member
|
Ok, sure |
GarboMuffin
changed the title
GarboMuffin
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1986