MIDI Synth#2525
Closed
samuellouf wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I'll take care of all of the formatting/linting later. Here is the block that is troubling me. |
Contributor
|
!format |
|
The formatting bot couldn't push changes. Either maintainer edit permission is disabled or the pull request is from an organization/non-personal account. The author can run terminal command 'npm run format' manually to format all files. |
Contributor
|
@samuellouf would you mind adding this to @lselden's MIDI extension #2022 instead of making a new one? Thanks! |
Contributor
Author
Yeah, of course! |
Contributor
Author
|
I'm closing this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This is the MIDI Synthesizer extension I talked about making in this comment.
For the moment, it is only in beta. I absolutely do not know how to do the "play note for X beats block". I don't know how to take care of tempo changes.