My extensions: ProjectFullscreen, L+Ratio, Temporary Lists

[R3d5t0n3GUY]

I would like to take a moment to credit LilyMakesThings for being the inspiration source for Temporary Lists. While her code was a reference for it, no AI was used in the making of any of these extensions

[R3d5t0n3GUY]

!format

[github-actions]

The formatting bot couldn't push changes. Either maintainer edit permission is disabled or the pull request is from an organization/non-personal account. The author can run terminal command 'npm run format' manually to format all files.

[SharkPool-SP]

I'm closing this for several reasons:

1. you have multiple extensions in 1 pr don't to that. You should split them up.

2. Your constants extension should be merged into the already existing math extension which already has several constants

3. Project fullscreen should be merged into the controls controls extension, or window controls, or the fullscreen extension which all already exist in the gallery.

4. Temporary variables + JSON does the exact same as temporary lists.

[LegoBrainBiker]

I'm closing this for several reasons:

1. you have multiple extensions in 1 pr don't to that. You should split them up.
2. Your constants extension should be merged into the already existing math extension which already has several constants
3. Project fullscreen should be merged into the controls controls extension, or window controls, or the fullscreen extension which all already exist in the gallery.
4. Temporary variables + JSON does the exact same as temporary lists.

json isn't effective for storing data, as it creates a lot of lag constantly parsing and stringifying lists

[R3d5t0n3GUY]

Your reasonings for closing this pull request are valid, and I respect them. But there were a few reasons why my pull request ended up like this.

1. You should split them up

I didn’t want to spam the repository with pull requests for different extensions, considering I would probably have to re-fork it every time one was approved when others were waiting for approval. In this way, I tried to not spam the Extension Review Team’s inboxes with notifications, although complications with my code and the format-checker bot might have already done that.

2. Project fullscreen should be merged into the controls controls extension, or window controls, or the fullscreen extension which all already exist in the gallery

ProjectFullscreen was made as a means for the project to access the EDITOR fullscreen, not the browser one, since no extension I could find already did that. And merging fullscreen extensions that do different things might cause confusion that I, in the moment, did not feel was worth the trouble trying to solve, so it had to be its own extension.

3. Temporary variables + JSON does the exact same as temporary lists

Sure, you could get around the need of Temporary Lists with the use of JSON and Temporary Variables (thanking Lily here again for inspiration), but, as @LegoBrainBiker has pointed out, JSON isn’t effective at storing, parsing, and stringifying lists (although I’m not sure if Temporary Lists is, either), and for-looping thread variables via JSON would probably not be a good idea, especially if running without screen refresh. I wanted to make my own iteration functions for thread lists.

4. Your constants extension should be merged into the already existing math extension which already has several constants

For the math constants extension I included in the pull request, I just felt like a single reporter block with a drop-down menu would suffice for my needs, considering that I felt like adding one block for each constant would not be as efficient as how I ended up implementing the extension. Also, the extension name (L+ Ratio) is clearly a joke, both on modern internet humor, and on how some math constants are referred to as ratios (golden, plastic, silver, etc). Just felt like making a pun

5. [] should be merged with [_]…

I didn’t know how to add extension blocks to existing categories, and I didn’t want to risk breaking the editor by overwriting a category and forcing everyone to update whatever projects my extensions are used in, since there’s already going to be enough of that from simply me updating said extensions. Only now, if I merged with an existing extension, that would likely cause more issues than I would have liked people to deal with, especially if it’s primitives that I overwrote.

[SharkPool-SP]

There are multiple improved json extension PRs that solve this. Lists use json, its just that the current extension handles it horribly

[GarboMuffin]

Submit temporary lists as its own separate thing

1 PR = 1 extension is how we operate. Anything larger is impossible to review and refactor. This email thread is one of maybe 20 I received today related to TurboWarp in some way so you could send a good few more before it matters.

If you think the existing fullscreen extension is lacking, just add more blocks. It currently has 3. Adding an extra couple is fine. You can add new blocks without breaking things.

I don't think we need an extension for getting mathematical constants (even if only because extension blocks are substantially slower than just writing the number out or using a regular variable)

[Brackets-Coder]

@R3d5t0n3GUY You can make one fork of the repository and make separate branches for each extension. Then make pull requests as @GarboMuffin stated above.

[R3d5t0n3GUY]

@Brackets-Coder Ah. I forgot about that. By the way, how’s your AmmoPhysics Extension going?

[Brackets-Coder]

@Brackets-Coder Ah. I forgot about that. By the way, how’s your AmmoPhysics Extension going?

coming along well, waiting for a 2nd review