Block count calc fix#46
Open
beauknowssoftware wants to merge 7 commits into
Open
Conversation
Jasper-Bekkers
approved these changes
Apr 9, 2026
Member
Jasper-Bekkers
left a comment
Jasper-Bekkers
left a comment
There was a problem hiding this comment.
Thanks for the correction @beauknowssoftware
It actually looks like this crate is using a helper still divide_up_by_multiple that made it into rust some time ago also: div_ceil we might want to address that too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous block count calculation worked for most resolutions. However, some degenerate resolutions received the wrong block counts.
Take a 2x7 image for example. The previous calculation would give it a block count of 1, since 2*7=14, and 14/16 rounded up was 1.
However, this image should have 2 blocks. A 2x4 block, and a 2x3 block.