Skip to content

Fixed crossbows, implemented fireworks both as ammo for crossbows and as standalone items#84

Merged
TogAr2 merged 9 commits into
TogAr2:masterfrom
RyeWollschlaeger:master
May 30, 2026
Merged

Fixed crossbows, implemented fireworks both as ammo for crossbows and as standalone items#84
TogAr2 merged 9 commits into
TogAr2:masterfrom
RyeWollschlaeger:master

Conversation

@RyeWollschlaeger

@RyeWollschlaeger RyeWollschlaeger commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

The crossbows were broken, the multishot enchantment was hardcoded to only shoot 3 arrows at a time no matter the enchantment level, and having too high quick charge lead to an item use duration of 0, which also broke the crossbows. Also implemented fireworks as ammo for crossbows, and to be able to be placed down normally.

Also made lerp(), prevPitch and prevYaw protected instead of private, and edited shootFromRotation() to use a different formula for it's yaw, which orbits around the shooter, instead of having the same pitch no matter what (this was needed for vanilla multishot parity).

Closes #75

@RyeWollschlaeger

Copy link
Copy Markdown
Contributor Author

Crossbows don't take item damage when shot. I don't know why. I'll need to look into that more

@RyeWollschlaeger RyeWollschlaeger marked this pull request as draft May 16, 2026 07:57
@TogAr2

TogAr2 commented May 17, 2026

Copy link
Copy Markdown
Owner

I simplified the crossbow loading logic, also fixing an issue where other players would not see the animation when you hold right mouse button for longer than the loading time (Minestom's FinishItemUseEvent automatically cancels the animation, so I don't use it anymore).
Could you tell me if the bug you described in the comment is still present?

@RyeWollschlaeger

RyeWollschlaeger commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Could you tell me if the bug you described in the comment is still present?

The bug seems to be gone now thank you. I'll add a commit removing the TODO and add some minor fixes

@RyeWollschlaeger RyeWollschlaeger marked this pull request as ready for review May 19, 2026 13:50
@TogAr2 TogAr2 merged commit 6b51480 into TogAr2:master May 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crossbow not loading arrows

2 participants