fix(instruments): deduplicate AngelOne rows, populate derivative names#60
Conversation
… derivative display names AngelOne's master lists symbols like NIFTY as both an AMXIDX index and a plain NSE equity — the parser now tracks index symbols and skips the spurious equity duplicate. Futures/options name column was always NULL; now generates human-readable labels (e.g. "NIFTY FUT 27-Mar-2026", "NIFTY 23000 CE 27-Mar-2026"). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes add deduplication logic to the AngelOne instrument parser to prevent symbols appearing as both indices and equities, and populate human-readable display names for derivative instruments (futures and options) that previously returned NULL values. Changes
Poem
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
AMXIDX) and plain equity in AngelOne's master (e.g. NIFTY, BANKNIFTY) are now deduplicated; the index row is kept, the spurious equity row is skipped.namecolumn was alwaysNULL. Now populated with human-readable labels:NIFTY FUT 27-Mar-2026(futures),NIFTY 23000 CE 27-Mar-2026(options). Applies to both brokers.Test plan
make cipasses (lint, typecheck, 349 tests, 81.78% coverage)namecolumn is populated after refresh🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes