additional_data: sources: add licence info#335
Open
BibianaC wants to merge 2 commits into
Open
Conversation
BibianaC
force-pushed
the
bc/add-grant-additional_data-licence
branch
from
af01824 to
fda34e0
Compare
Bjwebb
reviewed
Jun 10, 2026
| self._cache = {} | ||
|
|
||
| def update_additional_data(self, grant, source_file, additional_data): | ||
| additional_data[f"{self.ADDITIONAL_DATA_KEY}_LICENCE"] = self.LICENCE |
Contributor
There was a problem hiding this comment.
I'm not sure why we're doing _LICENCE here, compared to https://github.com/ThreeSixtyGiving/datastore/pull/258/changes#diff-d3929aef8ca975fa331395aa7d04c5dc0b85608c6aed7ab04f3a45cf32fa4095R15-R22 which is additional_data[self.ADDITIONAL_DATA_KEY]["source_license"].
BibianaC
force-pushed
the
bc/add-grant-additional_data-licence
branch
from
b56608d to
830d3fc
Compare
BibianaC
force-pushed
the
bc/add-grant-additional_data-licence
branch
from
830d3fc to
7fa3b96
Compare
mariongalley
requested review from
mrshll1001
and removed request for
mariongalley
|
Not sure how to test so asked for Matt's review instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #213
I have added the licence to the additional data sources.
The API will be done in a different PR.