Skip to content

test(control_plane): let core pick its own gateway port - #185

Merged
fylorn merged 1 commit into
devfrom
fix/control-plane-test-core-start
Sep 24, 2026
Merged

fylorn merged 1 commit into
devfrom
fix/control-plane-test-core-start

Conversation

@fylorn

@fylorn fylorn commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

The control-plane integration test passed a port it had just released to twcore --port; under load another process grabs it in the gap, core exits with "already in use", and the test only says core did not answer in 30 seconds. This failed the 2026.9.16 version-bump PR (#184) on the macOS runner.

  • Use --port 0 so core binds a system-chosen port itself (the flag exists for tests).
  • On timeout, report core's exit status and its stdout/stderr (kept in the test's own directory).

Reproduced locally by running six copies of the test binary in parallel: 3 failures in 30 runs before, 36 of 36 passing after.

🤖 Generated with Claude Code

…it did not start

The harness asked the OS for a free port, released it, and passed it to
twcore --port. Under load another process takes the port in that gap:
core exits with "already in use" and the test only reports that core did
not answer in 30 seconds. Reproduced locally with six copies of the test
binary in parallel (3 failures in 30 runs); with --port 0 the same load
passes 36 of 36. The v2026.9.16 bump PR hit this on the macOS runner.

When core still does not answer, the panic now includes its exit status
and its stdout/stderr, kept in the test's own directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fylorn
fylorn force-pushed the fix/control-plane-test-core-start branch from 03437c4 to d4d503c Compare September 24, 2026 18:30
@fylorn
fylorn merged commit e691960 into dev Sep 24, 2026
4 checks passed
@fylorn
fylorn deleted the fix/control-plane-test-core-start branch September 24, 2026 18:35
@fylorn fylorn mentioned this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant