[FIX] partner_*_archive_propagate: bug fixes and unit tests

[ntsirintanis]

No description provided.

[NL66278]

@ntsirintanis I cannot find anywhere in Odoo (or in OCA modules present for VluchtelingenWerk) any code to propagate archiving to children via action_archive.

Where did you find this?

openeyedev@laptop-ronald:src$ grep -nrI --exclude-dir=i18n "def action_archive("
odoo/addons/mrp/models/mrp_routing.py:109:    def action_archive(self):
odoo/addons/mrp/models/mrp_workcenter.py:274:    def action_archive(self):
odoo/addons/mrp/models/product.py:111:    def action_archive(self):
odoo/addons/mrp/models/product.py:405:    def action_archive(self):
odoo/addons/project/wizard/project_task_type_delete.py:27:    def action_archive(self):
odoo/addons/point_of_sale/models/account_journal.py:35:    def action_archive(self):
odoo/odoo/models.py:5088:    def action_archive(self):

[ntsirintanis]

@ntsirintanis I cannot find anywhere in Odoo (or in OCA modules present for VluchtelingenWerk) any code to propagate archiving to children via action_archive.

Where did you find this?

openeyedev@laptop-ronald:src$ grep -nrI --exclude-dir=i18n "def action_archive("
odoo/addons/mrp/models/mrp_routing.py:109:    def action_archive(self):
odoo/addons/mrp/models/mrp_workcenter.py:274:    def action_archive(self):
odoo/addons/mrp/models/product.py:111:    def action_archive(self):
odoo/addons/mrp/models/product.py:405:    def action_archive(self):
odoo/addons/project/wizard/project_task_type_delete.py:27:    def action_archive(self):
odoo/addons/point_of_sale/models/account_journal.py:35:    def action_archive(self):
odoo/odoo/models.py:5088:    def action_archive(self):

Yes, I rushed for that comment. So the problem (which is really minor, but it should be tackled) is that this

https://github.com/OCA/OCB/blob/4e41279573a36bd53cf25bdfa11d172c7391b5ae/odoo/models.py#L5088

calls this

https://github.com/OCA/OCB/blob/4e41279573a36bd53cf25bdfa11d172c7391b5ae/odoo/models.py#L5082

which ultimately messes up with our propagation logic here:

partner-contact/partner_archive_propagate/models/res_partner.py

Line 35 in eaa33e5

def write(self, vals):

but only when force_outside_ui = True. In these cases action_archive should not call toggle_active() but just write() directly. All these concern archiving via the gear menu, and nothing else

[NL66278]

@ntsirintanis OK, add explanation of Archive via action and Archive with Children button to USAGE section of README. If time, you might expand the usage with some commented screenshots as documentation.

[ntsirintanis]

@NL66278 pre-commit fails for an unrelated reason. Let's see if we can get these merged then, and cherry-pick to 18.0