fix: add tini as init system to reap zombie processes#339
Open
thisisgm wants to merge 1 commit into
Open
Conversation
Camoufox/Firefox child processes become defunct when they exit since Python (PID 1) doesn't reap orphans. Adding tini as the entrypoint handles this at the image level, removing the need for --init or init: true in compose. Ref: ThePhaseless#241
Owner
|
Hi, for docker run, there is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tiniin the Docker image and uses it as the entrypointContext
Python as PID 1 doesn't reap orphaned child processes. This was reported in #241 and the workaround was
init: truein compose, but users runningdocker rundirectly still hit it. Adding tini to the image fixes it for everyone.