fix: respect start/end boundaries in intro_sort heap-sort fallback - #15440
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
The heap_sort() call in intro_sort() ignored the start and end parameters, causing elements outside the requested range to be reordered when max_depth reached zero and the algorithm fell back to heap sort. Add optional start/end parameters to heapify() and heap_sort(), with default values preserving existing whole-array behavior. Update the intro_sort() call site to pass the correct range. Fixes TheAlgorithms#15434
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Checklist
The
heap_sort()call inintro_sort()ignored thestartandendparameters, causing elements outside the requested range to be reordered whenmax_depthreached zero and the algorithm fell back to heap sort.Changes:
start/endparameters toheapify()andheap_sort()helpers withinintro_sort.py, with default values preserving existing whole-array behavior (backward compatible)intro_sort()call site at line 194 to pass the correct subrange(start, end)toheap_sort()Validation:
ruff check sorts/intro_sort.pypassesFixes #15434