Skip to content

fix: respect start/end boundaries in intro_sort heap-sort fallback - #15440

Open
dajiaohuang wants to merge 1 commit into
TheAlgorithms:masterfrom
dajiaohuang:fix/intro-sort-heapsort-boundaries
Open

dajiaohuang wants to merge 1 commit into
TheAlgorithms:masterfrom
dajiaohuang:fix/intro-sort-heapsort-boundaries

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

The heap_sort() call in intro_sort() ignored the start and end parameters, causing elements outside the requested range to be reordered when max_depth reached zero and the algorithm fell back to heap sort.

Changes:

  • Add optional start/end parameters to heapify() and heap_sort() helpers within intro_sort.py, with default values preserving existing whole-array behavior (backward compatible)
  • Update the intro_sort() call site at line 194 to pass the correct subrange (start, end) to heap_sort()

Validation:

Fixes #15434

The heap_sort() call in intro_sort() ignored the start and end
parameters, causing elements outside the requested range to be
reordered when max_depth reached zero and the algorithm fell back
to heap sort.

Add optional start/end parameters to heapify() and heap_sort(), with
default values preserving existing whole-array behavior. Update the
intro_sort() call site to pass the correct range.

Fixes TheAlgorithms#15434
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Sep 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intro_sort heap-sort fallback ignores start and end boundaries

1 participant