Skip to content

fix: respect start/end boundaries in intro_sort heap-sort fallback - #15439

Closed
dajiaohuang wants to merge 1 commit into
TheAlgorithms:masterfrom
dajiaohuang:fix/intro-sort-heapsort-boundaries
Closed

dajiaohuang wants to merge 1 commit into
TheAlgorithms:masterfrom
dajiaohuang:fix/intro-sort-heapsort-boundaries

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

The heap_sort() call in intro_sort() ignored the start and end parameters, causing elements outside the requested range to be reordered when max_depth reached zero and the algorithm fell back to heap sort.

Changes:

  • Add optional start/end parameters to heapify() and heap_sort(), with default values preserving existing whole-array behavior
  • Update the intro_sort() call site to pass the correct subrange to heap_sort()
  • Add a regression doctest for the subrange heap-sort fallback case

Validation:

Fixes #15434

The heap_sort() call in intro_sort() ignored the start and end
parameters, causing elements outside the requested range to be
reordered when max_depth reached zero and the algorithm fell back
to heap sort.

Add optional start/end parameters to heapify() and heap_sort(), with
default values preserving existing whole-array behavior. Update the
intro_sort() call site to pass the correct range. Add a regression
doctest for the subrange heap-sort fallback case.

Fixes TheAlgorithms#15434
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 25, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@dajiaohuang, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intro_sort heap-sort fallback ignores start and end boundaries

1 participant