Skip to content

fix(sorts): make power_sort generic over Comparable items - #15438

Open
wanjinhao1 wants to merge 2 commits into
TheAlgorithms:masterfrom
wanjinhao1:agent/fix-15234-power-sort-comparable
Open

wanjinhao1 wants to merge 2 commits into
TheAlgorithms:masterfrom
wanjinhao1:agent/fix-15234-power-sort-comparable

Conversation

@wanjinhao1

@wanjinhao1 wanjinhao1 commented Sep 25, 2026 •

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Part of #15234 (does not close the tracking issue).

What

  • Adds a Comparable protocol (__lt__ only) and a PEP 695 TypeVar bound so power_sort accepts any iterable of mutually comparable items (Iterable[T] → list[T]) instead of a bare list. The key path stays Callable[[T], Any] per the audit note in the tracker discussion.
  • Rewrites the run-detection and merge comparisons to use only < (the protocol guarantees nothing else): the ascending-run check >= becomes not (... < ...) and the merge tie left <= right becomes not (right < left), which preserves stability for total orders.
  • Adds a mixed-type failure doctest (power_sort([1, "a"]) → TypeError).
  • Registers power_sort in the shared SORTS battery and the non-comparable rejection list in tests/test_sorts.py.

Why

power_sort.py is one of the remaining unchecked comparison sorts in the #15234 checklist, with no open PR and no assignee.

Validation

  • python3 -m doctest sorts/power_sort.py — all doctests pass (including the new TypeError case)
  • python3 -m pytest tests/test_sorts.py -q — 395 passed (includes power_sort across the full shared CASES battery and the [1, "a"] rejection test)

Note: one algorithm per PR per the tracker guidance. This PR was completed with AI assistance under the supervision of the account owner (@wanjinhao1) — happy to address any review feedback.

wanjinhao1 and others added 2 commits September 25, 2026 22:03
- Add a Comparable protocol and TypeVar bound (PEP 695) so power_sort
  accepts any iterable of mutually comparable items instead of bare list
- Rewrite run detection and merge comparisons to use only __lt__, which
  is all the protocol guarantees
- Add doctest + shared test battery coverage, including the mixed-type
  TypeError failure mode
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 25, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@wanjinhao1, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 25, 2026
@cclauss cclauss reopened this Sep 25, 2026
@algorithms-keeper algorithms-keeper Bot added the enhancement This PR modified some existing files label Sep 25, 2026
@wanjinhao1
wanjinhao1 force-pushed the agent/fix-15234-power-sort-comparable branch from 9e3b140 to 03e45c0 Compare September 25, 2026 14:43
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants