fix(sorts): accept lt-only items in recursive insertion sort - #15436
Open
tuttucodes wants to merge 1 commit into
Open
tuttucodes wants to merge 1 commit into
tuttucodes wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
insert_nextused<=, so a collection whose elements implement only<raisedTypeErroreven though those elements are orderable. Compare the next element with<instead and bind the generic type parameter toComparable. Add a shared regression case with a custom<-only element. Existing sort tests cover strings, floats, and the mixed-typeTypeErrorcase.Part of #15234. This is one algorithm from the umbrella issue, so the issue should remain open.
Verification
python3.14 -m doctest sorts/recursive_insertion_sort.pyuvx --python 3.14 pytest tests/test_sorts.py -q— 384 passeduvx ruff check sorts/recursive_insertion_sort.py tests/test_sorts.pyuvx ruff format --check sorts/recursive_insertion_sort.py tests/test_sorts.pyuvx pre-commit run --all-filesChecklist