Skip to content

feat(conversions): add input validation and fix bugs in Roman Numerals and Excel Column Title conversions#14870

Closed
aoright wants to merge 1 commit into
TheAlgorithms:masterfrom
aoright:fix-conversions-validation
Closed

feat(conversions): add input validation and fix bugs in Roman Numerals and Excel Column Title conversions#14870
aoright wants to merge 1 commit into
TheAlgorithms:masterfrom
aoright:fix-conversions-validation

Conversation

@aoright

@aoright aoright commented Jun 29, 2026

Copy link
Copy Markdown

This PR improves input validation, adds lowercase input support, and fixes boundary bugs across two conversion files:

  1. roman_numerals.py:

    • roman_to_int: Seamlessly converts lowercase input strings (e.g. "iii" -> 3) and raises a proper ValueError with clear messages for empty or invalid inputs.
    • int_to_roman: Validates that the input is an integer in the range 1 <= number <= 3999. Raises ValueError for out-of-range/non-integer inputs instead of returning incorrect values (e.g., int_to_roman(-5) used to return "CMXCV").
  2. excel_title_to_column.py:

    • excel_title_to_column: Replaces the bypassable assert column_title.isupper() with a proper input validation raising ValueError for empty or non-alphabetic inputs. Added lowercase title support.

@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@aoright, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant