Skip to content

Intervention testing#185

Merged
morganle-48 merged 20 commits into
mainfrom
intervention-testing
Apr 17, 2026
Merged

Intervention testing#185
morganle-48 merged 20 commits into
mainfrom
intervention-testing

Conversation

@morganle-48

Copy link
Copy Markdown
Collaborator

This branch was used to fix the issues with pre-emptive transplants and then add the new HHD intervention using the simpy interrupt function.

@morganle-48 morganle-48 requested a review from yiwen-h as a code owner April 1, 2026 14:12
@morganle-48

Copy link
Copy Markdown
Collaborator Author

Closes #182 and #183

@yiwen-h

yiwen-h commented Apr 15, 2026

Copy link
Copy Markdown
Member

Hello! We need to sort the failing checks before approving - do you need help with that @morganle-48? maybe we could put some time in to investigate and fix together as a pair programming thing

@morganle-48

Copy link
Copy Markdown
Collaborator Author

That would be ideal - managed to fix the other two but then ran short on time. I'll send you an invite

Comment thread renal_capacity_model/config_values.py Outdated
Comment thread renal_capacity_model/model.py Outdated
Comment thread renal_capacity_model/model.py Outdated
Morgan Lucy (MLCSU) and others added 6 commits April 17, 2026 12:03

@yiwen-h yiwen-h left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@morganle-48 morganle-48 merged commit a014dd8 into main Apr 17, 2026
4 checks passed
@morganle-48 morganle-48 deleted the intervention-testing branch April 17, 2026 11:11
@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.14286% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.63%. Comparing base (f4d67d4) to head (fd31c4d).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
renal_capacity_model/model.py 50.37% 59 Missing and 7 partials ⚠️
renal_capacity_model/load_scenario.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   84.77%   79.63%   -5.15%     
==========================================
  Files           9        9              
  Lines         703      815     +112     
  Branches       78       94      +16     
==========================================
+ Hits          596      649      +53     
- Misses         98      150      +52     
- Partials        9       16       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants