Intervention testing#185
Merged
Merged
Conversation
Fixing duplicate deaths caused by broken SimPy interrupt handling
Collaborator
Author
Member
|
Hello! We need to sort the failing checks before approving - do you need help with that @morganle-48? maybe we could put some time in to investigate and fix together as a pair programming thing |
Collaborator
Author
|
That would be ideal - managed to fix the other two but then ran short on time. I'll send you an invite |
yiwen-h
requested changes
Apr 17, 2026
Co-authored-by: YiWen Hon <yiwen.hon1@nhs.net>
Co-authored-by: YiWen Hon <yiwen.hon1@nhs.net>
Co-authored-by: YiWen Hon <yiwen.hon1@nhs.net>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 84.77% 79.63% -5.15%
==========================================
Files 9 9
Lines 703 815 +112
Branches 78 94 +16
==========================================
+ Hits 596 649 +53
- Misses 98 150 +52
- Partials 9 16 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch was used to fix the issues with pre-emptive transplants and then add the new HHD intervention using the simpy interrupt function.