Skip to content

fsv: fix the sign of sky130.itf's resistive etch - #12407

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:sky130-itf-resistive-etch
Nov 21, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:sky130-itf-resistive-etch

Conversation

@maliberty

Copy link
Copy Markdown
Member

sky130.itf in the fsv tests had the sign of RESISTIVE_ONLY_ETCH reversed. A positive etch narrows a conductor, which is how both the ITF format and pex read it. The file widened met1 through met5 and fieldpoly and narrowed li1. Now li1 is the only layer that expands.

  • sky130.itf: the sign of every RESISTIVE_ONLY_ETCH is flipped.
  • TestItf and TestNetwork take the new values: a minimum-width met1 or met2 wire is 0.101 µm wide in silicon rather than 0.179 µm.

On gcd, pex's resistance per net goes from 0.85 of rcx's (median, 10th–90th percentile 0.78–0.94) to 0.995 (0.99–1.00). Capacitance is unchanged: the capacitive etch is 0 on every layer, and pex models built from this stack stay valid.

A positive etch narrows a conductor. sky130.itf had the signs reversed:
met1 through met5 and fieldpoly widened, and li1 narrowed. Now li1 is
the only layer that expands.

A minimum-width met1 or met2 wire is now 0.101 um wide in silicon rather
than 0.179 um. On gcd, pex's resistance per net goes from 0.85 of rcx's
(median) to 0.995. Capacitance is unchanged: the capacitive etch is 0 on
every layer, and models built from the stack stay valid.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty self-assigned this Nov 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the resistive etch values in the sky130.itf technology file, flipping the signs of RESISTIVE_ONLY_ETCH for several conductors (met1-met5, fieldpoly, and li1). Correspondingly, it updates the unit tests in TestItf.cpp and the network test calculations/comments in TestNetwork.cpp to reflect the new wire width and resistance per micrometer values under the corrected etch signs. I have no feedback to provide.

@maliberty
maliberty marked this pull request as ready for review November 21, 2026 03:12
@maliberty
maliberty requested a review from a team as a code owner November 21, 2026 03:12
@maliberty
maliberty merged commit c151bf9 into The-OpenROAD-Project:master Nov 21, 2026
20 of 21 checks passed
@maliberty
maliberty deleted the sky130-itf-resistive-etch branch November 21, 2026 03:12
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-21T03:12:49.300821Z
We couldn’t complete this review. Comment @codex review to try again.
97499b5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant