Repository navigation
Conversation
A positive etch narrows a conductor. sky130.itf had the signs reversed: met1 through met5 and fieldpoly widened, and li1 narrowed. Now li1 is the only layer that expands. A minimum-width met1 or met2 wire is now 0.101 um wide in silicon rather than 0.179 um. On gcd, pex's resistance per net goes from 0.85 of rcx's (median) to 0.995. Capacitance is unchanged: the capacitive etch is 0 on every layer, and models built from the stack stay valid. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request updates the resistive etch values in the sky130.itf technology file, flipping the signs of RESISTIVE_ONLY_ETCH for several conductors (met1-met5, fieldpoly, and li1). Correspondingly, it updates the unit tests in TestItf.cpp and the network test calculations/comments in TestNetwork.cpp to reflect the new wire width and resistance per micrometer values under the corrected etch signs. I have no feedback to provide.
c151bf9
into
The-OpenROAD-Project:master
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sky130.itfin the fsv tests had the sign ofRESISTIVE_ONLY_ETCHreversed. A positive etch narrows a conductor, which is how both the ITF format and pex read it. The file widened met1 through met5 and fieldpoly and narrowed li1. Now li1 is the only layer that expands.sky130.itf: the sign of everyRESISTIVE_ONLY_ETCHis flipped.TestItfandTestNetworktake the new values: a minimum-width met1 or met2 wire is 0.101 µm wide in silicon rather than 0.179 µm.On gcd, pex's resistance per net goes from 0.85 of rcx's (median, 10th–90th percentile 0.78–0.94) to 0.995 (0.99–1.00). Capacitance is unchanged: the capacitive etch is 0 on every layer, and pex models built from this stack stay valid.