Repository navigation
Conversation
The definition of the library in @zlib is a bit problematic as it has its headers as part of its `srcs = []` (as direct names e.g. `zlib.h`), but also in the `hdrs = []` with a fully qualified name `zlib/include/zlib.h`. It _also_ as an includes with a prefix of `zlib/include/` which could allow users to include just the short name (e.g. `zlib.h`). Alas, now the same header can be reached two ways: via the name found in the srcs (but that is a private header), or via the -I path in zlib/include. This sometimes results in the compiler finding one version first resulting in issues such as ``` openroad/odb/src/def/defzlib/defzlib.cpp:43:10: error: use of private header from outside its module: 'zlib.h' [-Wprivate-header] ``` TL;DR: fix this by always using the fully qualified name. Signed-off-by: Henner Zeller <h.zeller@acm.org>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the include paths for zlib headers to "zlib/include/zlib.h" and "zlib/include/zconf.h" across several files. Feedback suggests removing the redundant inclusion of "zconf.h" in "asset_gzip.cpp", as it is already included by "zlib.h".
gadfort
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definition of the library in @zlib is a bit problematic as it has its headers as part of its
srcs = [](as direct names e.g.zlib.h), but also in thehdrs = []with a fully qualified namezlib/include/zlib.h.It also as an includes with a prefix of
zlib/include/which could allow users to include just the short name (e.g.zlib.h). Alas, now the same header can be reached two ways: via the name found in the srcs (but that is a private header), or via the -I path in zlib/include. This sometimes results in the compiler finding one version first resulting in issues such asTL;DR: fix this by always using the fully qualified name.