Repository navigation
Conversation
report_long_wires printed one more wire than requested. Signed-off-by: Xia Chao <shapirolutts@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an off-by-one error in Resizer::reportLongWires by moving the limit check to the beginning of the loop, ensuring that at most count wires are reported. It also updates the affected test golden files and introduces a new test case (report_long_wires_limit) to verify this behavior. I have no feedback to provide as the changes are correct and well-tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
report_long_wiresprinted one more wire than the count asks for. It now stops at count.Type of Change
Impact
report_long_wires 3reports three wires instead of four. The existing test goldens that captured the extra line are updated.Verification
./etc/Build.sh).Related Issues
None.