Skip to content

rsz: report at most the requested number of long wires - #12400

Open
xia-chao wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
xia-chao:rsz-longwires-limit
Open

xia-chao wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
xia-chao:rsz-longwires-limit

Conversation

@xia-chao

@xia-chao xia-chao commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

report_long_wires printed one more wire than the count asks for. It now stops at count.

Type of Change

  • Bug fix

Impact

report_long_wires 3 reports three wires instead of four. The existing test goldens that captured the extra line are updated.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

Related Issues

None.

report_long_wires printed one more wire than requested.

Signed-off-by: Xia Chao <shapirolutts@gmail.com>
@xia-chao
xia-chao requested a review from a team as a code owner November 20, 2026 10:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an off-by-one error in Resizer::reportLongWires by moving the limit check to the beginning of the loop, ensuring that at most count wires are reported. It also updates the affected test golden files and introduces a new test case (report_long_wires_limit) to verify this behavior. I have no feedback to provide as the changes are correct and well-tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant