Repository navigation
Conversation
The READMEs listed option names that the commands do not accept, and a `-verbose` option that eliminate_dead_logic does not have. Signed-off-by: Xia Chao <shapirolutts@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in openroad/cts/README.md and openroad/rsz/README.md to align with command option changes. Specifically, it renames the '-root_buffer' option to '-root_buf' in the CTS documentation, updates the '-skip_size_down_fanout' option to '-skip_size_down' in the Resizer documentation, and removes the deprecated '-verbose' option documentation from the 'eliminate_dead_logic' command. There are no review comments to evaluate, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rsz and cts READMEs listed option names that the commands do not accept. They now match the names the commands parse.
Type of Change
Impact
Readers copying the option tables no longer hit an unknown-keyword error.
Verification
./etc/Build.sh).Related Issues
None.