Repository navigation
Conversation
-path_group knew only reg2reg, in2reg, reg2out, in2out and gated_clock; any other name warned (RSZ-0227) and repaired every path. A group made with group_path, a path group through a set of nets for instance, could not scope repair. A name that is not one of the five but names a group the SDC defines is taken as is: an endpoint is repaired when it has a path in that group, and its group slack is the worst of those paths, as for the built-in groups, without their structural endpoint classification. A use: a hierarchical design flattened at its top repairs only the paths through the nets between two blocks, so that repair never works on a block's own paths. OpenSTA's Sdc::deleteNetBefore keeps such a group sound when repair deletes one of its nets. repair_timing_path_group7: a group -through one net is repaired, its worst slack improving; a net named in a group_path -through is destroyed through OpenDB, as a resizer move does, and write_sdc no longer names it. CRIT_VT_SWAP still works on the fanin cone of the group's endpoints that some startpoint reaches, as for the built-in groups. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
There was a problem hiding this comment.
Code Review
This pull request introduces support for SDC-defined path groups (via group_path) in the resizer's path group filtering mechanism. It adds a new PathGroupType::kUser enum value, updates PathGroupFilter to recognize and handle these user-defined path groups by their names, and bypasses standard endpoint kind checks for them. Additionally, a new regression test repair_timing_path_group7 is added to verify this functionality. I have no feedback to provide as there are no review comments.
clang-tidy's include cleaner flags the use in groupEndpointSlack, on a line this pull request changes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
The same test fell back to unrestricted repair on base but scoped repair to the SDC group at this head. Beyond the gcd/ASAP7 test and linked XSTile run, has this been validated on another technology for paths that share an endpoint with the selected group but are outside it? (AI-assisted review.) |
|
A curious question. Tell me more about why you ask: is there something in the change that you expect to behave differently on another technology? It is in endpoint selection and in which slack repair judges an endpoint by ( Here are the measurements I made. ORFS designs after
No RSZ-0227 in any of these runs, and the same picture on all nine. At an endpoint with paths both in the group and outside it, repair looks only at the group's worst path: it stops once that meets the margin and keeps a move that helps the group. The outside paths share cells with the group's, so they move too, in either direction; on nangate45/gcd the design WNS ended worse than before repair (-87 → -101). Closing those is left to a later unrestricted repair. Not tested: post-CTS databases and CRIT_VT_SWAP (no multi-VT library loaded). |
For a group the SDC defines, PathGroupFilter::startpointInGroup accepts every startpoint, so CRIT_VT_SWAP's group fanout covered the whole design and its walk took the full fanin cone of the group's violating endpoints. That cone also feeds the endpoints' paths outside the group: on gcd/ASAP7 with a group -through one net, 67 of the 125 cells the phase swapped lay on no path of the group. Under such a group the phase now takes the cells on the group's worst path to each violating endpoint (PathGroupFilter::findWorstSlackPath), nearest the endpoint first, under the same per-endpoint cap. The built-in groups keep the fanin cone walk; their swaps already all lie on a path of the group (reg2reg on the same design: 123 swapped, none off the group). repair_timing_path_group7 counts the VT swaps repair makes and those on no path of the group: 69 before, 0 now. The group ends with 28 violating endpoints at -10.750 ps instead of 27 at -9.769 ps: only each endpoint's worst group path is swapped now, not its whole cone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
While measuring this I found that a |
repair_timing -path_group <name>now repairs a group the SDC defines withgroup_path. Before, onlyreg2reg,in2reg,reg2out,in2outandgated_clockwere known: any other name warned (RSZ-0227) and repaired every path, so a group could not scope repair.The change
A name that is not one of the five but names a group the SDC defines is taken as is: an endpoint is repaired when it has a path in that group, and its group slack is the worst of those paths, as for the built-in groups, without their structural endpoint classification. A name that is neither still warns.
A use: a hierarchical design flattened at its top repairs only the paths through the nets between two blocks (
group_path -through), so that repair never works on a block's own paths.Test
repair_timing_path_group7:-throughone net is repaired, and its worst slack improves;group_path -throughis destroyed through OpenDB, as a resizer move does, andwrite_sdcno longer names it;CRIT_VT_SWAPunder the group swaps only cells on the group's worst path to each violating endpoint: the test counts the VT swaps repair makes that lie on no path of the group, and expects none. (The fanin cone of the group's endpoints, which the built-in groups use, also feeds those endpoints' paths outside the group.)rsz's regressions pass, 330 of 330 under
//openroad/rsz/....The integration that uses it: The-OpenROAD-Project/bazel-orfs#1541.
🤖 Generated with Claude Code