Repository navigation
rsz: Use data buffers only for hold repair - #12360
Merged
minjukim55 merged 1 commit intoNov 18, 2026
Merged
minjukim55 merged 1 commit into
minjukim55 merged 1 commit into
Conversation
What: Hold repair no longer temporarily switches the resizer to a buffer list that includes clock buffers. Clock buffers are now always excluded from the data buffer list, so the exclude_clock_buffers_ flag is removed. Why: Hold repair overrode exclude_clock_buffers_ and buffer_cells_ with SetAndRestore. Only the two inputs were restored afterwards; the derived library data, lowest drive buffer, port buffer and fast buffer sizes kept the values computed for the clock-inclusive list, and every new buffer-derived cache needed its own invalidation around hold repair. It also put clock buffers on data paths, which conflicts with keeping data and clock buffers disjoint, and report_buffers named a different hold buffer than the one repair_timing -hold actually inserted. The exception was added because nangate45 has no delay cells. Current hold buffer selection (delay/area metric with delay-footprint, VT and site filtering) no longer needs it: on PDKs with delay cells the chosen hold buffer is unchanged, and on nangate45 BUF_X1 replaces CLKBUF_X1 with a few more hold buffers and every hold violation still repaired. How: Remove the two SetAndRestore pairs from both repairHold() entry points, drop exclude_clock_buffers_, and always skip clock buffers in getBufferList() and findBuffersNoPruning(). Update the hold goldens. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the exclude_clock_buffers_ configuration option from the Resizer class, making the exclusion of clock buffers the default behavior. The temporary override of this option in repairHold has been removed. Consequently, standard buffers (BUF_X1) are now consistently used instead of clock buffers (CLKBUF_X1) for hold repairs, and the test golden files have been updated to reflect the updated buffer counts, area, and slack metrics. I have no feedback to provide as there are no review comments.
minjukim55
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Symptom
repairHold()overridesexclude_clock_buffers_andbuffer_cells_withSetAndRestore, but only those two inputs are restored. Derived state (lib_data_,buffer_lowest_drive_,port_buffer_,buffer_fast_sizes_) keeps the clock-inclusive values, and the next command does not rebuild it becausebuffer_cells_is non-empty.swappable_cells_cache_.clear()calls and #12236 needs extra stale checks for VT library data.report_buffersnames a different hold buffer than the onerepair_timing -holdinserts (nangate45,repair_hold1.def):Changes
flowchart LR subgraph Before A1[repairHold] -->|SetAndRestore exclude_clock_buffers_=false| B1[buffer_cells_ cleared] B1 --> C1[resizePreamble rebuilds data + clock list and lib_data_] C1 --> D1[restore list only, derived state stays clock-inclusive] end subgraph After A2[repairHold] --> C2[resizePreamble reuses the data buffer list] endrepairHold()SetAndRestoreofexclude_clock_buffers_andbuffer_cells_exclude_clock_buffers_CLKBUF_X1BUF_X1SetAndRestorepairs from bothrepairHold()entry points.exclude_clock_buffers_and always skip clock buffers ingetBufferList()andfindBuffersNoPruning().Impact
dlygate4sd3_1, gf180dlyc_2).3_place.odbwith a largeHOLD_SLACK_MARGIN); hold TNS is 0 in every run:Related
Details
Background
CLKBUF_X1has a higher delay thanBUF_X1at the same area. When #5693 excluded clock buffers everywhere,gcd_resizeended with an error because of the hold buffer count, so #5752 kept clock buffers for hold repair "until we have a better approach".gcd_resizeinserts 98 instead of 84 hold buffers and repairs every hold violation.buffer_cells_is overridden only byrepairClkNets(), which runsresizePreamble()before the override, so the buffer-derived data always reflects the data buffer policy. If #12285 lands first, itsexclude_clock_buffers_ &&condition and the four hold-specific cache clears become unnecessary.Golden changes
gcd_resize(tcl and py): 84 to 98 hold buffers, design area 751 to 762 um^2.repair_hold2,repair_hold7,repair_hold8,repair_hold11,repair_hold_clock_as_data,repair_hold_clock_as_data_clk_tree,repair_timing_path_group5: moreBUF_X1hold buffers instead ofCLKBUF_X1; hold WNS stays non-negative.repair_hold1,repair_hold1_hier,repair_hold3,repair_hold12: same buffer count,BUF_X1instead ofCLKBUF_X1, small slack changes.repair_timing_crpr: hold is not fully repairable in this test before or after; hold WNS -0.076 to -0.082.Testing
bazel test //openroad/... //test/...: all tests pass (4965 executed, 4 skipped).clang-format --dry-run --Werroron the changed sources passes.3_place.odb.