Repository navigation
Conversation
Pick a pad pin's connection layer and access points at its core-facing edge, not its bond pad. A port on the pad pin's metal shares that pin's position instead of being routed through the pad. Fixes The-OpenROAD-Project#12171 Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new PinGeometry utility to encapsulate pin edge and geometry calculations, refactoring Pin::determineEdge and updating the global router and CUGR to handle pad/macro pin access points and same-net port connections. Feedback on the changes highlights a potential std::out_of_range crash in Pin::determineEdge when using .at() on layers without pin boxes, and a potential null pointer dereference in findCoveringITerm when querying the type of a null tech layer. Additionally, it is recommended to filter out null or non-routing layers when populating pin_shapes for better safety and efficiency.
|
@osamahammad21 FYI |
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40c84314b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| port.setOnGridPosition(pin.getOnGridPosition()); | ||
| port.setConnectionLayer(pin.getConnectionLayer()); |
There was a problem hiding this comment.
Resolve covered ports through the ITerm when reloading guides
When reloading an ODB saved after the first, no-pin_access CUGR run of the new fixture, the reconstructed pad/port position is not covered by the saved guides: reconstruction selects y=1050000, while CUGR connects at y=1016400. ensurePinsPositions() consequently passes the port to findOnGridPositions(), which evaluates pin.getBoxes().at(conn_layer). The copied connection layer is Metal2, but this port only has Metal5 geometry, so guide loading throws std::out_of_range, breaking callers such as estimate_parasitics -global_routing. Restored-guide pin adjustment needs to honor the covering-ITerm association instead of independently falling back through the port's original geometry.
Useful? React with 👍 / 👎.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude comments: == Priority 1 (correctness) ==
== Priority 2 (QoR) ==
== Priority 3 (testing) ==
|
…ROAD into grt-pad-pin-12171
When guides loaded from the database miss a pad pin, the pad pin moves to a covered access point; a port on its metal now moves with it instead of falling back to the bond pad. Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
A shape that touches the voted edge and another edge now counts as facing the voted edge, so its layer stays a connection candidate. Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
…ROAD into grt-pad-pin-12171
pad_pin_edge now has pads facing north, south, east, and west. pad_pin_edge_restore_cugr undoes an ECO so CUGR restores the pad nets from their guides. Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Pick a pad pin's connection layer and access points at its core-facing edge, not its bond pad. A port on the pad pin's metal shares that pin's position instead of being routed through the pad.
Fixes #12171
Summary
In the gf180mcu analog pad
gf180mcu_fd_io__asig_5p0, pinASIG5Vhas Metal2 stripes that reach the core-facing edge and a Metal5 bond pad on the outer side, behind the pad's obstructions. Global routing had two problems with it:Pin::determineEdgepicked Metal5, the only pin layer whose preferred direction matches the edge, so the connection landed on the bond pad. With DRT access points, the bond pad's many access points could still outvote the stripes.place_io_terminalsputs the top-level port on the bond pad, and GRT routed it as one more pin, through or around the pad.In the reporter's design, two connections of about 150 µm took 11,986 µm of wire and left 30 overflow entries after 51 congestion iterations.
The fix applies to both FastRoute and CUGR:
determineEdgechooses only among layers that have a shape at the pin's edge.Type of Change
Impact
Net wirelength on a model of the reporter's pad (8 Metal2 stripes, port on the bond pad) with LibreLane's GRT settings. The reporter's ODB isn't attached to the issue, so their design hasn't been re-run.
pin_accessNo run needs extra iterations after the fix. For reference, the west net routes at 159 µm when the bond pad isn't part of the pin, and CUGR routes the south net at 294 µm with the port detached.
pad_pin_edgetest design,detailed_routefinishes with 0 violations and 159 µm, and runs no wire to the port. DRT code is unchanged.estimate_parasitics -global_routingjoins a covered port to its grid position with a straight wire, so the port's estimated wire now spans the pad instead of following the old route.Verification
./etc/Build.sh).