Repository navigation
Conversation
`make run-yosys` started Yosys with the flow's environment and RUN_YOSYS_ARGS, by default yosys_keep.tcl, an example that loads the synthesis result with yosys_load.tcl and lists the modules kept in hierarchical synthesis. 519ae62 (March 2025) added it to explore and report on synthesis results. Nothing in flow, the tests, tools or the CI files calls the target or sources either script; flow/scripts/README.md was their only mention. yosys_load.tcl reads $(RESULTS_DIR)/1_synth.v, which the default synthesis no longer writes: it writes 1_2_yosys.v and 1_synth.odb. A list of the kept modules is a one-line Yosys command when it is wanted, and `make yosys` still opens Yosys with the flow's environment. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
marked this pull request as ready for review
November 20, 2026 15:43
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
make run-yosys,RUN_YOSYS_ARGS,flow/scripts/yosys_keep.tcl,flow/scripts/yosys_load.tcland their two sections offlow/scripts/README.md.Why it was there. 519ae62 (March 2025) added
make run-yosysto explore and report on synthesis results: it starts Yosys with the flow's environment andRUN_YOSYS_ARGS, by defaultyosys_keep.tcl, an example that loads the synthesis result withyosys_load.tcland writes the list of modules kept in hierarchical synthesis toreports/.../keep.txt.Why it can go.
flow/scripts/README.mdwas their only mention.yosys_load.tclreads$(RESULTS_DIR)/1_synth.v, which the default synthesis no longer writes: it writes1_2_yosys.vand1_synth.odb.make yosysstill opens Yosys with the flow's environment..phony, so it was never phony.Checked. On nangate45/gcd,
make -n runandmake -n do-2_1_floorplanprint the same commands before and after. I have not runmake synth run-yosyson master.🤖 Generated with Claude Code