Skip to content

make: delete run-yosys, yosys_keep.tcl and yosys_load.tcl - #4872

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:delete-run-yosys
Open

oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:delete-run-yosys

Conversation

@oharboe

@oharboe oharboe commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Deletes make run-yosys, RUN_YOSYS_ARGS, flow/scripts/yosys_keep.tcl, flow/scripts/yosys_load.tcl and their two sections of flow/scripts/README.md.

Why it was there. 519ae62 (March 2025) added make run-yosys to explore and report on synthesis results: it starts Yosys with the flow's environment and RUN_YOSYS_ARGS, by default yosys_keep.tcl, an example that loads the synthesis result with yosys_load.tcl and writes the list of modules kept in hierarchical synthesis to reports/.../keep.txt.

Why it can go.

  • Nothing in flow, the tests, tools or the CI files calls the target or sources either script. flow/scripts/README.md was their only mention.
  • yosys_load.tcl reads $(RESULTS_DIR)/1_synth.v, which the default synthesis no longer writes: it writes 1_2_yosys.v and 1_synth.odb.
  • Listing the kept modules is done ad hoc when it is wanted, with a one-line Yosys command; it does not need a target, a variable and two scripts in the flow. make yosys still opens Yosys with the flow's environment.
  • The target was declared with a lower-case .phony, so it was never phony.

Checked. On nangate45/gcd, make -n run and make -n do-2_1_floorplan print the same commands before and after. I have not run make synth run-yosys on master.

🤖 Generated with Claude Code

`make run-yosys` started Yosys with the flow's environment and
RUN_YOSYS_ARGS, by default yosys_keep.tcl, an example that loads the
synthesis result with yosys_load.tcl and lists the modules kept in
hierarchical synthesis. 519ae62 (March 2025) added it to explore and
report on synthesis results.

Nothing in flow, the tests, tools or the CI files calls the target or
sources either script; flow/scripts/README.md was their only mention.
yosys_load.tcl reads $(RESULTS_DIR)/1_synth.v, which the default
synthesis no longer writes: it writes 1_2_yosys.v and 1_synth.odb. A
list of the kept modules is a one-line Yosys command when it is wanted,
and `make yosys` still opens Yosys with the flow's environment.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe requested a review from vvbandeira November 20, 2026 13:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'run-yosys' target from the Makefile, deletes the corresponding documentation in the README, and removes two unused Yosys helper scripts. There are no review comments to address.

@oharboe
oharboe marked this pull request as ready for review November 20, 2026 15:43
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 1316431 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants