Repository navigation
Conversation
`make klayout` started KLayout through klayout.sh with no arguments. 9e0472f (September 2023) added it with the support for a locally built KLayout. Nothing in flow, docs, tools or the CI files calls it, it is not documented, and klayout.sh can be run as it is. It was also declared with a lower-case .phony, so it was never phony. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
marked this pull request as ready for review
November 20, 2026 15:43
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the
klayouttarget fromflow/Makefile.Why it was there. 9e0472f (September 2023, "makefile: support locally built and installed klayout") added
make klayout, which starts KLayout throughklayout.shwith no arguments.Why it can go. Nothing in flow, docs, tools or the CI files calls it, and it is not documented.
klayout.shcan be run as it is, and the targets that open a result in KLayout (klayout_<file>,gds,drc,lvs) do not go through it. It was also declared with a lower-case.phony, so it was never phony.Checked. On nangate45/gcd,
make -n runandmake -n do-2_1_floorplanprint the same commands before and after.This and the pull request that declares
run.PHONYtouch adjacent lines, so whichever merges second needs a trivial rebase.🤖 Generated with Claude Code