Skip to content

make: delete the klayout target - #4871

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:delete-make-klayout
Open

oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:delete-make-klayout

Conversation

@oharboe

@oharboe oharboe commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Deletes the klayout target from flow/Makefile.

Why it was there. 9e0472f (September 2023, "makefile: support locally built and installed klayout") added make klayout, which starts KLayout through klayout.sh with no arguments.

Why it can go. Nothing in flow, docs, tools or the CI files calls it, and it is not documented. klayout.sh can be run as it is, and the targets that open a result in KLayout (klayout_<file>, gds, drc, lvs) do not go through it. It was also declared with a lower-case .phony, so it was never phony.

Checked. On nangate45/gcd, make -n run and make -n do-2_1_floorplan print the same commands before and after.

This and the pull request that declares run .PHONY touch adjacent lines, so whichever merges second needs a trivial rebase.

🤖 Generated with Claude Code

`make klayout` started KLayout through klayout.sh with no arguments.
9e0472f (September 2023) added it with the support for a locally
built KLayout. Nothing in flow, docs, tools or the CI files calls it,
it is not documented, and klayout.sh can be run as it is. It was also
declared with a lower-case .phony, so it was never phony.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the klayout target and its associated recipe from the flow/Makefile. I have no feedback to provide.

@oharboe
oharboe requested a review from vvbandeira November 20, 2026 13:27
@oharboe
oharboe marked this pull request as ready for review November 20, 2026 15:43
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit cec8045 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants