Repository navigation
Conversation
`.phony: run` in lower case is an ordinary target named .phony, not make's .PHONY, so `run` was not phony: with a file or directory named run beside the Makefile, `make run` printed "'run' is up to date" and ran nothing. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
marked this pull request as ready for review
November 20, 2026 15:42
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.phony: runinflow/Makefileis lower case, which make reads as an ordinary target named.phony, sorunwas never phony. This declares it.PHONY.What it changes. With a file or directory named
runbeside the Makefile:and nothing runs. With this change the script runs.
Why keep the target.
make run(0eaec59, September 2024) runsRUN_SCRIPTin OpenROAD with the flow's environment. It is documented (RUN_SCRIPTandRUN_LOG_NAME_STEMinvariables.yaml,docs/contrib/MakefileContract.md) and used by the tests inflow/testand by bazel-orfs.The two other lower-case
.phonylines in the file sit on targets nothing uses; they are deleted in their own pull requests. This one and themake klayoutdeletion touch adjacent lines, so whichever merges second needs a trivial rebase.🤖 Generated with Claude Code