Skip to content

make: run is declared .PHONY - #4870

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:phony-run
Open

oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:phony-run

Conversation

@oharboe

@oharboe oharboe commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

.phony: run in flow/Makefile is lower case, which make reads as an ordinary target named .phony, so run was never phony. This declares it .PHONY.

What it changes. With a file or directory named run beside the Makefile:

$ mkdir run
$ make DESIGN_CONFIG=./designs/nangate45/gcd/config.mk run RUN_SCRIPT=x.tcl
make: 'run' is up to date.

and nothing runs. With this change the script runs.

Why keep the target. make run (0eaec59, September 2024) runs RUN_SCRIPT in OpenROAD with the flow's environment. It is documented (RUN_SCRIPT and RUN_LOG_NAME_STEM in variables.yaml, docs/contrib/MakefileContract.md) and used by the tests in flow/test and by bazel-orfs.

The two other lower-case .phony lines in the file sit on targets nothing uses; they are deleted in their own pull requests. This one and the make klayout deletion touch adjacent lines, so whichever merges second needs a trivial rebase.

🤖 Generated with Claude Code

`.phony: run` in lower case is an ordinary target named .phony, not
make's .PHONY, so `run` was not phony: with a file or directory named
run beside the Makefile, `make run` printed "'run' is up to date" and
ran nothing.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the casing of the '.phony' target to '.PHONY' in flow/Makefile to ensure proper GNU Make behavior. There are no review comments, and I have no feedback to provide.

@oharboe
oharboe requested a review from vvbandeira November 20, 2026 13:27
@oharboe
oharboe marked this pull request as ready for review November 20, 2026 15:42
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit f4ebd1e · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants