Skip to content

util: delete genMassive.py - #4868

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-genmassive
Open

oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-genmassive

Conversation

@oharboe

@oharboe oharboe commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Deletes flow/util/genMassive.py.

Why it was there. #59 (June 2021, "genMassive.py for massive runs and AutoTuner") added it to generate design-of-experiments sweeps: one config.mk per combination of the knob lists edited at the top of the file, a runMassive.sh that runs make on each, and a script that collects metrics with genMetrics.py. The AutoTuner it was written alongside lives in tools/AutoTuner today and does not use it.

Why it may be able to go.

  • Nothing in the repository calls it or documents it: flow, docs, tools/AutoTuner, .github, Jenkinsfile, docker.
  • Its own comments say parts of it do not work (GR_OVERFLOW: "currently it does not work").
  • The metrics script it writes calls genMetrics.py without --logs, --reports and --results, which f094e24 (March 2026) made required:
    $ python3 util/genMetrics.py -x -p sky130hd -d gcd -v doe -o out.json
    genMetrics.py: error: the following arguments are required: --logs, --reports, --results
    
  • Yet every change that renames or removes a flow variable it writes has to edit it (synth: drop the ABC delay target that never reached ABC #4586, place: add GPL_PLACE_IOS for global_placement -place_ios #4685 this autumn).

This one is less certain than the other dead code: it is a stand-alone script, and someone may run it by hand. Does anyone use it? If so, say so here and this can be closed.

Checked. The flow/test Python tests pass, and black 26.10.1 is clean.

🤖 Generated with Claude Code

genMassive.py (#59, June 2021) generated a design-of-experiments sweep:
one config.mk per combination of the knob lists set at the top of the
file, a runMassive.sh that runs make on each, and a script that collects
metrics with genMetrics.py. It was written alongside the first AutoTuner
scripts, which moved on to tools/AutoTuner and do not use it.

Nothing in the repository calls it, its own comments say parts of it
do not work (GR_OVERFLOW), and the metrics script it writes calls
genMetrics.py without --logs, --reports and --results, which have been
required since f094e24 (March 2026):

  genMetrics.py: error: the following arguments are required: --logs,
  --reports, --results

It is still edited by every change that renames or removes a flow
variable it writes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes the Python script used for generating massive Design of Experiments (DoE) runscripts and configuration files. I have no feedback to provide as there are no review comments.

@oharboe
oharboe requested a review from vvbandeira November 20, 2026 13:19
@oharboe
oharboe marked this pull request as ready for review November 20, 2026 13:19
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit ee8acd7 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants