Repository navigation
Conversation
genMassive.py (#59, June 2021) generated a design-of-experiments sweep: one config.mk per combination of the knob lists set at the top of the file, a runMassive.sh that runs make on each, and a script that collects metrics with genMetrics.py. It was written alongside the first AutoTuner scripts, which moved on to tools/AutoTuner and do not use it. Nothing in the repository calls it, its own comments say parts of it do not work (GR_OVERFLOW), and the metrics script it writes calls genMetrics.py without --logs, --reports and --results, which have been required since f094e24 (March 2026): genMetrics.py: error: the following arguments are required: --logs, --reports, --results It is still edited by every change that renames or removes a flow variable it writes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
marked this pull request as ready for review
November 20, 2026 13:19
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
flow/util/genMassive.py.Why it was there. #59 (June 2021, "genMassive.py for massive runs and AutoTuner") added it to generate design-of-experiments sweeps: one
config.mkper combination of the knob lists edited at the top of the file, arunMassive.shthat runsmakeon each, and a script that collects metrics withgenMetrics.py. The AutoTuner it was written alongside lives intools/AutoTunertoday and does not use it.Why it may be able to go.
GR_OVERFLOW: "currently it does not work").genMetrics.pywithout--logs,--reportsand--results, which f094e24 (March 2026) made required:This one is less certain than the other dead code: it is a stand-alone script, and someone may run it by hand. Does anyone use it? If so, say so here and this can be closed.
Checked. The
flow/testPython tests pass, and black 26.10.1 is clean.🤖 Generated with Claude Code