Repository navigation
Conversation
- calBuffer.py and calPath.py (4ab4a45, October 2020) counted the hold buffers in, and per path of, the hard-coded report reports/gf12/bp_single/min_delay_report_osta.rpt. - appendStatsToDb.py (92b6715, March 2020), a python2 script that appended a design's metadata JSON to a master test list and wrote it out as CSV. - addDummyToLef.py (initial commit, December 2019), which inserted a DUMMY macro, copied from a reference macro, into a LEF. No Makefile, script, workflow or document in the repository calls any of them, and none had a caller in the commit that added it. Since then they have only been touched by repository-wide formatting and clean-up commits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several obsolete Python scripts from the repository, including a LEF utility script, a test metadata database updater, and two report parsing scripts. I have no feedback to provide as there are no review comments to evaluate.
oharboe
marked this pull request as ready for review
November 20, 2026 13:18
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes four scripts in
flow/utilthat nothing calls:calBuffer.pyhold*buffers in the hard-codedreports/gf12/bp_single/min_delay_report_osta.rptcalPath.pyhold*buffers per path in the same hard-coded reportappendStatsToDb.pyaddDummyToLef.pyWhy they can go. No Makefile, script, workflow, Jenkinsfile, Dockerfile or document in the repository calls any of them, and none had a caller in the commit that added it either (
git grepof that commit's*.mk, Makefiles,*.sh,*.py,*.yml,*.md). Since then they have only been touched by repository-wide formatting and clean-up commits. A GitHub code search finds them only in listings of copied ORFS trees.Checked. The
flow/testPython tests pass, and black 26.10.1 is clean.🤖 Generated with Claude Code