Skip to content

util: delete four scripts nothing calls - #4867

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-unused-util-scripts
Open

oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-unused-util-scripts

Conversation

@oharboe

@oharboe oharboe commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Deletes four scripts in flow/util that nothing calls:

Script Added What it did
calBuffer.py 4ab4a45, Oct 2020 counted the distinct hold* buffers in the hard-coded reports/gf12/bp_single/min_delay_report_osta.rpt
calPath.py 4ab4a45, Oct 2020 histogram of hold* buffers per path in the same hard-coded report
appendStatsToDb.py 92b6715, Mar 2020 appended a design's metadata JSON to a master test list and wrote it out as CSV; python2 shebang
addDummyToLef.py initial commit, Dec 2019 inserted a DUMMY macro, copied from a reference macro, into a LEF

Why they can go. No Makefile, script, workflow, Jenkinsfile, Dockerfile or document in the repository calls any of them, and none had a caller in the commit that added it either (git grep of that commit's *.mk, Makefiles, *.sh, *.py, *.yml, *.md). Since then they have only been touched by repository-wide formatting and clean-up commits. A GitHub code search finds them only in listings of copied ORFS trees.

Checked. The flow/test Python tests pass, and black 26.10.1 is clean.

🤖 Generated with Claude Code

- calBuffer.py and calPath.py (4ab4a45, October 2020) counted the
  hold buffers in, and per path of, the hard-coded report
  reports/gf12/bp_single/min_delay_report_osta.rpt.
- appendStatsToDb.py (92b6715, March 2020), a python2 script that
  appended a design's metadata JSON to a master test list and wrote it
  out as CSV.
- addDummyToLef.py (initial commit, December 2019), which inserted a
  DUMMY macro, copied from a reference macro, into a LEF.

No Makefile, script, workflow or document in the repository calls any
of them, and none had a caller in the commit that added it. Since then
they have only been touched by repository-wide formatting and clean-up
commits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several obsolete Python scripts from the repository, including a LEF utility script, a test metadata database updater, and two report parsing scripts. I have no feedback to provide as there are no review comments to evaluate.

@oharboe
oharboe requested a review from vvbandeira November 20, 2026 13:18
@oharboe
oharboe marked this pull request as ready for review November 20, 2026 13:18
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 61b35e0 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants