Repository navigation
Conversation
make run_test ran $(TEST_DIR)/core_tests.sh with GNU parallel on the hosts listed in $(TEST_DIR)/nodes.txt; clean_test removed the job log and test/logs it left. Both came with the initial commit. core_tests.sh and nodes.txt were deleted as stale in 2152d38 (The-OpenROAD-Project#2886, February 2025), so run_test fails at once: bash: line 1: .../flow/test/core_tests.sh: No such file or directory make: *** [.../flow/util/utils.mk:144: run_test] Error 1 Nothing else writes test/parallel.log or test/logs, so nuke no longer depends on clean_test; it still runs clean_issues and removes results, logs, reports and objects as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
run_test and clean_test were the only readers of TEST_DIR; with them gone nothing in the repository reads it (flow, docs, etc, tools, .github, Jenkinsfile, docker). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
marked this pull request as ready for review
November 20, 2026 13:17
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
make run_test,make clean_testandTEST_SCRIPTfromflow/util/utils.mk, dropsclean_testfromnuke's prerequisites, and, in a second commit, deletesTEST_DIRfromflow/scripts/variables.mk: the two targets were its only readers in the repository.Why they were there. Since the initial commit,
run_testran$(TEST_DIR)/core_tests.shwith GNU parallel over ssh on the hosts in$(TEST_DIR)/nodes.txt;clean_testremoved the job log andtest/logs.Why they can go. #2886 (2152d38, February 2025) deleted
core_tests.shandnodes.txtas stale, sorun_testfails at once:Nothing in the repository (flow, docs, .github, Jenkinsfile, docker) calls
run_testorclean_test, and nothing else writestest/parallel.logortest/logs, sonukehas nothing to lose by not depending onclean_test. It still runsclean_issuesand removesresults,logs,reportsandobjects.Checked. On nangate45/gcd,
make -nofdo-2_1_floorplan do-3_3_place_gp do-5_2_route do-6_reportprints the same commands before and after, and themake -prule database differs only by the deleted rules andnuke's prerequisites. Theflow/testPython tests pass.🤖 Generated with Claude Code