Skip to content

flow: delete run_test and clean_test - #4866

Open
oharboe wants to merge 2 commits into
The-OpenROAD-Project:masterfrom
oharboe:remove-run-test
Open

oharboe wants to merge 2 commits into
The-OpenROAD-Project:masterfrom
oharboe:remove-run-test

Conversation

@oharboe

@oharboe oharboe commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes make run_test, make clean_test and TEST_SCRIPT from flow/util/utils.mk, drops clean_test from nuke's prerequisites, and, in a second commit, deletes TEST_DIR from flow/scripts/variables.mk: the two targets were its only readers in the repository.

Why they were there. Since the initial commit, run_test ran $(TEST_DIR)/core_tests.sh with GNU parallel over ssh on the hosts in $(TEST_DIR)/nodes.txt; clean_test removed the job log and test/logs.

Why they can go. #2886 (2152d38, February 2025) deleted core_tests.sh and nodes.txt as stale, so run_test fails at once:

$ make DESIGN_CONFIG=./designs/nangate45/gcd/config.mk run_test
bash: line 1: .../flow/test/core_tests.sh: No such file or directory
make: *** [.../flow/util/utils.mk:144: run_test] Error 1

Nothing in the repository (flow, docs, .github, Jenkinsfile, docker) calls run_test or clean_test, and nothing else writes test/parallel.log or test/logs, so nuke has nothing to lose by not depending on clean_test. It still runs clean_issues and removes results, logs, reports and objects.

Checked. On nangate45/gcd, make -n of do-2_1_floorplan do-3_3_place_gp do-5_2_route do-6_report prints the same commands before and after, and the make -p rule database differs only by the deleted rules and nuke's prerequisites. The flow/test Python tests pass.

🤖 Generated with Claude Code

make run_test ran $(TEST_DIR)/core_tests.sh with GNU parallel on the
hosts listed in $(TEST_DIR)/nodes.txt; clean_test removed the job log
and test/logs it left. Both came with the initial commit.

core_tests.sh and nodes.txt were deleted as stale in 2152d38 (The-OpenROAD-Project#2886,
February 2025), so run_test fails at once:

  bash: line 1: .../flow/test/core_tests.sh: No such file or directory
  make: *** [.../flow/util/utils.mk:144: run_test] Error 1

Nothing else writes test/parallel.log or test/logs, so nuke no longer
depends on clean_test; it still runs clean_issues and removes results,
logs, reports and objects as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the run_test and clean_test targets from flow/util/utils.mk and updates the nuke target in flow/Makefile to remove the dependency on clean_test. I have no feedback to provide on these changes.

@oharboe
oharboe requested a review from vvbandeira November 20, 2026 13:04
run_test and clean_test were the only readers of TEST_DIR; with them
gone nothing in the repository reads it (flow, docs, etc, tools,
.github, Jenkinsfile, docker).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe marked this pull request as ready for review November 20, 2026 13:17
@openroad-ci

openroad-ci commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 52064df · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants