Skip to content

flow: delete the KLayout DRC and route guide viewers - #4865

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-klayout-drc-viewers
Open

oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-klayout-drc-viewers

Conversation

@oharboe

@oharboe oharboe commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Deletes make klayout_tr_rpt and make klayout_guides, their scripts flow/util/viewDrc.py and flow/util/viewGuide.py, and the GUIDE_NET variable only they read.

Why they were there. d4fd960 (May 2020) added klayout_tr_rpt to show the detailed router's DRCs in KLayout as a marker database; bb1bfd3 (June 2020) added klayout_guides to show one net's global route guides the same way.

Why they can go. Both open $(RESULTS_DIR)/5_route.def, and no rule has made that file since #363 (dbb2c9e, November 2021) passed ODB between steps instead of DEF; the per-step DEF rule makes 5_route.odb.def.

$ make DESIGN_CONFIG=./designs/nangate45/gcd/config.mk -n klayout_tr_rpt
make: *** No rule to make target 'results/nangate45/gcd/base/5_route.def', needed by 'klayout_tr_rpt'.  Stop.

Nothing else in the repository (flow, docs, tools/AutoTuner, .github, Jenkinsfile, docker) refers to the targets, the scripts or GUIDE_NET; a GitHub code search finds them only in forks' copies of flow/Makefile.

Replacement. The OpenROAD GUI's DRC Viewer loads 5_route_drc.rpt over the routed design (docs/tutorials/FlowTutorial.md, "DRC Viewer").

Checked. On nangate45/gcd, make -n of do-2_1_floorplan do-3_3_place_gp do-5_2_route do-6_report prints the same commands before and after, and the make -p rule database differs only by the two deleted targets. The flow/test Python tests pass, and black 26.10.1 is clean.

🤖 Generated with Claude Code

make klayout_tr_rpt and make klayout_guides opened
$(RESULTS_DIR)/5_route.def in KLayout with the detailed router's DRC
report (flow/util/viewDrc.py) or the global route guides of the net
GUIDE_NET (flow/util/viewGuide.py) as a marker database.

Both have depended on a file no rule makes since the flow went from
DEF to ODB between steps (dbb2c9e, The-OpenROAD-Project#363, November 2021): the route
step writes 5_route.odb, and the only DEF rule is 5_route.odb.def.

  $ make DESIGN_CONFIG=./designs/nangate45/gcd/config.mk -n klayout_tr_rpt
  make: *** No rule to make target
  'results/nangate45/gcd/base/5_route.def', needed by 'klayout_tr_rpt'.  Stop.

Nothing else in the repository refers to the two targets, the two
scripts or GUIDE_NET. The OpenROAD GUI's DRC Viewer loads the same
5_route_drc.rpt over the routed design, as the "DRC Viewer" section of
docs/tutorials/FlowTutorial.md describes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the klayout_tr_rpt and klayout_guides targets from the Makefile, along with their associated KLayout Python scripts for viewing TritonRoute DRC reports and FastRoute guides. I have no feedback to provide.

@oharboe
oharboe marked this pull request as ready for review November 20, 2026 13:18
@oharboe
oharboe requested a review from vvbandeira November 20, 2026 13:18
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 34cbc5e · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants