Repository navigation
Conversation
make klayout_tr_rpt and make klayout_guides opened $(RESULTS_DIR)/5_route.def in KLayout with the detailed router's DRC report (flow/util/viewDrc.py) or the global route guides of the net GUIDE_NET (flow/util/viewGuide.py) as a marker database. Both have depended on a file no rule makes since the flow went from DEF to ODB between steps (dbb2c9e, The-OpenROAD-Project#363, November 2021): the route step writes 5_route.odb, and the only DEF rule is 5_route.odb.def. $ make DESIGN_CONFIG=./designs/nangate45/gcd/config.mk -n klayout_tr_rpt make: *** No rule to make target 'results/nangate45/gcd/base/5_route.def', needed by 'klayout_tr_rpt'. Stop. Nothing else in the repository refers to the two targets, the two scripts or GUIDE_NET. The OpenROAD GUI's DRC Viewer loads the same 5_route_drc.rpt over the routed design, as the "DRC Viewer" section of docs/tutorials/FlowTutorial.md describes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
marked this pull request as ready for review
November 20, 2026 13:18
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
make klayout_tr_rptandmake klayout_guides, their scriptsflow/util/viewDrc.pyandflow/util/viewGuide.py, and theGUIDE_NETvariable only they read.Why they were there. d4fd960 (May 2020) added
klayout_tr_rptto show the detailed router's DRCs in KLayout as a marker database; bb1bfd3 (June 2020) addedklayout_guidesto show one net's global route guides the same way.Why they can go. Both open
$(RESULTS_DIR)/5_route.def, and no rule has made that file since #363 (dbb2c9e, November 2021) passed ODB between steps instead of DEF; the per-step DEF rule makes5_route.odb.def.Nothing else in the repository (flow, docs, tools/AutoTuner, .github, Jenkinsfile, docker) refers to the targets, the scripts or
GUIDE_NET; a GitHub code search finds them only in forks' copies offlow/Makefile.Replacement. The OpenROAD GUI's DRC Viewer loads
5_route_drc.rptover the routed design (docs/tutorials/FlowTutorial.md, "DRC Viewer").Checked. On nangate45/gcd,
make -nofdo-2_1_floorplan do-3_3_place_gp do-5_2_route do-6_reportprints the same commands before and after, and themake -prule database differs only by the two deleted targets. Theflow/testPython tests pass, and black 26.10.1 is clean.🤖 Generated with Claude Code