Repository navigation
use CUGR on sky130hd and sky130hs designs - #4862
eder-matheus wants to merge 5 commits into
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new flow variable, GLOBAL_ROUTE_CUGR_ADJUSTMENT_SCALE, which scales routing layer adjustments when using the CUGR global router. It also enables CUGR by default for the sky130hd and sky130hs platforms and adds congestion reporting for CUGR. A review comment identifies a critical issue in scale_layer_adjustments where fully blocked layers (adjustment of 1.0) would be incorrectly scaled and partially opened, and suggests restricting scaling to adjustments strictly between 0 and 1.
| foreach layer [[ord::get_db_tech] getLayers] { | ||
| set adjustment [$layer getLayerAdjustment] | ||
| if { $adjustment != 0 } { | ||
| log_cmd set_global_routing_layer_adjustment [$layer getName] \ | ||
| [expr { $adjustment * $scale }] | ||
| } | ||
| } |
There was a problem hiding this comment.
If a routing layer has an adjustment of 1 (or 1.0), it means the layer is completely blocked for global routing (e.g., met1 is often fully blocked to prevent global routing on it). Scaling this adjustment by a factor less than 1 (e.g., 0.5) would reduce the adjustment to 0.5, which partially opens the layer for global routing. This can lead to unexpected global routing on blocked layers, causing routing issues or detailed routing failures.
To prevent this, we should only scale adjustments that are strictly between 0 and 1 (exclusive).
foreach layer [[ord::get_db_tech] getLayers] {
set adjustment [$layer getLayerAdjustment]
if { $adjustment > 0 && $adjustment < 1 } {
log_cmd set_global_routing_layer_adjustment [$layer getName] \\
[expr { $adjustment * $scale }]
}
}
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 4 with regression(s), 0 without a comparable baseline. ❌ sky130hd/chameleon base — 1 failing metric(s)
❌ sky130hd/ibex base — 1 failing metric(s)
❌ sky130hd/riscv32i base — 1 failing metric(s)
❌ sky130hs/jpeg base — 1 failing metric(s)
|
Makes CUGR the global router for every sky130hd and sky130hs design. All other platforms keep FastRoute.
Changes
GLOBAL_ROUTE_USE_CUGR ?= 1in the sky130hd and sky130hs platformconfig.mk. A design or the command line can still set it to 0.GLOBAL_ROUTE_CUGR_ADJUSTMENT_SCALE, default 0.5. When CUGR routes, it multiplies every layer's global routing adjustment (fromFASTROUTE_TCLorROUTING_LAYER_ADJUSTMENT) before the firstglobal_route.5_1_grt.odb, so antenna repair after detailed routing uses them too.global_route.tclrunsreport_congestionafter antenna repair, so the log shows the remaining overflow.