Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new --pids-limit command-line option to the flow/util/docker_shell script, allowing users to restrict the maximum number of processes inside the container (defaulting to -1 for unlimited). The feedback correctly points out that the current validation regex is too permissive, as it allows invalid values like 0 or integers less than -1 (e.g., -2) which will cause the container engine to fail at runtime. A tighter validation check has been suggested to ensure the limit is either -1 or a positive integer.
pid limit check update Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
a2da66b to
6a6f3f2
Compare
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
Also applicable to docker.