Skip to content

Unlimit PIDs for podman usage - #4858

Open
jeffng-or wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:unlimit-pids
Open

jeffng-or wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:unlimit-pids

Conversation

@jeffng-or

Copy link
Copy Markdown
Contributor

Also applicable to docker.

@jeffng-or jeffng-or self-assigned this Nov 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new --pids-limit command-line option to the flow/util/docker_shell script, allowing users to restrict the maximum number of processes inside the container (defaulting to -1 for unlimited). The feedback correctly points out that the current validation regex is too permissive, as it allows invalid values like 0 or integers less than -1 (e.g., -2) which will cause the container engine to fail at runtime. A tighter validation check has been suggested to ensure the limit is either -1 or a positive integer.

Comment thread flow/util/docker_shell Resolved
pid limit check update

Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
@openroad-ci

openroad-ci commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 962c6ac · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants