Skip to content

flow: rename set/reset_place_config to *_placer_config - #4857

Merged
jhkim-pii merged 2 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-gpl-set-placer-config
Nov 19, 2026
Merged

jhkim-pii merged 2 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-gpl-set-placer-config

Conversation

@minjukim55

Copy link
Copy Markdown
Member

Follow the OpenROAD rename of set_place_config / reset_place_config to set_placer_config / reset_placer_config (OpenROAD branch secure-gpl-set-placer-config).

  • global_place.tcl: the two -place_ios calls use the new names.
  • util.tcl: helper renamed to place_pins_args_to_placer_config.
  • tools/OpenROAD points at the OpenROAD commit with the rename.

No behavior change.

OpenROAD renamed the placement configuration commands.

Signed-off-by: Minju Kim <mkim@precisioninno.com>
Signed-off-by: Minju Kim <mkim@precisioninno.com>
@minjukim55 minjukim55 self-assigned this Nov 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the global placement scripts (global_place.tcl and util.tcl) to rename set_place_config and reset_place_config to set_placer_config and reset_placer_config respectively, along with updating the associated helper function and comments. Additionally, it updates the tools/OpenROAD submodule commit. There are no review comments, and I have no feedback to provide.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 37adc04 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@jhkim-pii
jhkim-pii merged commit f550444 into The-OpenROAD-Project:master Nov 19, 2026
12 checks passed
@jhkim-pii
jhkim-pii deleted the secure-gpl-set-placer-config branch November 19, 2026 19:29
@maliberty

Copy link
Copy Markdown
Member

Merging this without merging The-OpenROAD-Project/OpenROAD#12386 breaks ORFS-Nightly which uses the head of OR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants