Clearbit migration#107
Draft
keegansmith21 wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to how insitution logos are retrieved.
Made a new function in api.ts
entityImageLoader(). Which takes an entity and a size. When supplied a country entity, it returns the appropriate logo via thecokiImageLoader()function. When supplied with an insitution entity, returns a new route to our backend api host.Added a new route and handler in our backend API:
/logos/:entityIdfetchLogoHandler()takes an entityId and a size parameter. Queries the backend KV store to retrieve the domain of the entity if it exists. Then fetches the logo (using the size param) from logo.dev and returns the jpeg image asynchronously.Updates all
cokiImageLoader()calls to instead use the newentityImageLoader()function.Also updates the D1 database loading. Wrangler does not like how we're loading the data, so I made a script to load it in batches. This seems to be a wrangler bug, If it ever gets fixed, we should revert it to the simpler way.