fix(record): persist L1 extraction failure diagnostics#252
Open
YOMXXX wants to merge 1 commit into
Open
Conversation
Signed-off-by: 李冠辰 <liguanchen@xiaomi.com>
Collaborator
|
@YOMXXX 4 PRs in one day tackling L1 extraction robustness — JSON parsing tolerance, dedup hardening, failure diagnostics persistence, and auto-retry. Great coverage! We'll review them one by one 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description | 描述
Persist L1 extraction failure diagnostics when the extraction model returns empty output, content-filter prose, or malformed JSON instead of the expected scene array.
Before this change,
parseExtractionResult()returned an empty array for these failures and the pipeline reportedextracted=0, leaving operators with no durable evidence of what the model actually returned. This matches the failure mode in #104, where content filtering made L1 appear to silently stop.This PR:
.metadata/l1-extraction-failures.jsonlRelated Issue | 关联 Issue
Fixes #104
Verification | 验证
npm test -- src/core/record/l1-extractor-diagnostics.test.tsfailed with missing diagnostics filenpm test -- src/core/record/l1-extractor-diagnostics.test.tsnpm testnpm run build