Repository navigation
Conversation
Resolve the SKILL.md reference-table conflict by listing both JS dialogs and the new element waits for the interaction-details reference. The entry point stays within its byte budget.
Keep both JavaScript dialog control and the new video tool: register both DSH tools and schemas, mark both as control-plane methods, and gate dialog decisions and video start on user interrupts. Tighten the DSH skill entry point so the combined dialog and video guidance stays within its 4,500-byte budget after Windows CRLF checkout.
Expose both wait-for-element and dialog on the DSH browser_page tool, keeping each action's guidance in the tool description and both in the expected action maps.
Keep JavaScript dialogs alongside structured extraction: register both DSH tools and list both sets of error reasons. In the CLI skill, take main's singular ref wording but keep the shorter reference-loading sentence so the entry point stays within its 7,100-byte budget after Windows CRLF checkout.
The large-frame encoder check failed on a final-frame colour sample. The test only bundles video modules and type-only dialog changes; rerun to separate CI timing from a branch regression.
Adopt the DSH bsk_* tool names for the dialog action: tool maps, skill entry point, interaction reference and session-resolution label now use bsk_page/bsk_session. List dialog in the README's bsk_page actions, and keep both the Added dialog entry and the Changed namespace entry.
Keep --no-auto-dialog alongside the new background-by-default focus handling: the CLI sends both focused and no_auto_dialog, and the DSH start tool maps noFocus to --focus/--no-focus and noAutoDialog to --no-auto-dialog. Keep the dialog parse test before main's renamed background session test.
The focus mapping cases from Tencent#447 still looked up browser_session after Tencent#446 renamed the tool, so they failed on main as well.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native
confirm()andprompt()dialogs are currently accepted automatically, so agents cannot cancel a confirmation or supply prompt input. This change leaves those dialogs pending and adds explicit status, accept and dismiss commands.Fixes #359.
bsk dialog status,bsk dialog accept [text]andbsk dialog dismiss, with optional tab selection and a dialog ID to reject stale decisions. Omitted prompt text preserves the default; an empty string clears it.alertandbeforeunloadby default.session start --no-auto-dialogleaves all four types pending, including a beforeunload choice to stay on the page.dialog_pendingpromptly when a dialog blocks a tool, including lifecycle waits. Dialog control can run while the session is busy and still enforces ownership and user interruption. Track the actual native command until it settles, preserve cleanup without replaying input, and handle manual closure, consecutive dialogs and debugger detach.The pending response ends the original CLI wait, not execution inside Chrome. Handling the dialog may resume the already-sent native operation; it is never replayed. The original evaluation return value is not recovered. Callers inspect the page afterwards and wait while
execution_pendingis true.The video encoder regression also waits for frame presentation after seeking before sampling pixels; its existing color assertions are unchanged.
Local validation:
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --lockedpnpm lintpnpm --filter @browser-skill/extension compilepnpm ext:testandpnpm ext:buildnode --test scripts/*.test.mjs, including LF/CRLF skill budget checksnode scripts/check-skill-bundles.mjsandnode scripts/check-crate-skill.mjsnode scripts/check-dsh-package.mjsagainst an actual npm archiveclick-dialogs.browser.test.tsandclick.browser.test.ts. The dialog cases are included by the existing CI glob.