Repository navigation
fix: don't credit the What's new and Report tabs to Joseph - #8
Merged
Merged
Conversation
The tabs entry claimed "Joseph's idea". Nobody's sure that's true — the report link came out of a note from Dad and a suggestion from me, and the changelog itself was new. Credit removed rather than reassigned, because guessing again would be the same mistake. The rule in the file header now says so: only use `credit` when you actually know whose it was. The people reading this remember exactly what they did and didn't suggest, and a credit on the wrong entry sours the ones that are right. "Spotted by Joseph" stays on the multi-turn moves entry, which is his. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017SGWh8kJjQsy4QB9pigonf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top changelog entry claimed "★ Joseph's idea" for the What's new and Report tabs. That isn't established — the report link came out of a note from Dad and a suggestion from me, and the changelog itself was new. I inferred the credit rather than knowing it.
Removed rather than reassigned to Dad, since nobody's certain and guessing a second time would be the same mistake.
"★ Spotted by Joseph" stays on the multi-turn moves entry. That one is genuinely his, and it's the one that matters.
The durable bit
The rule in
changelog.js's header invited this, so it now says the quiet part:Checks
npm run test:run— 177 pass.npm run build— clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017SGWh8kJjQsy4QB9pigonf
Generated by Claude Code