Skip to content

chore: expand CodeRabbit config with per-package review guidance #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaharPak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: expand CodeRabbit config with per-package review guidance #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b99db73
chore: expand CodeRabbit config with per-package review guidance
SaharPak Jun 11, 2026
3e192e8
Merge branch 'main' into chore/coderabbit-config
amirbahador-hub Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# yaml-language-server: $schema=https://docs.coderabbit.ai/schema.json
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
language: en-US
early_access: false

reviews:
profile: chill
request_changes_workflow: false
high_level_summary: true
poem: false
review_status: true
auto_review:
enabled: true
Expand All @@ -13,6 +15,38 @@ reviews:
- main
path_filters:
- "!**/pnpm-lock.yaml"
- "!**/dist/**"
- "!**/.turbo/**"
- "!**/node_modules/**"
- "!**/*.snap"
path_instructions:
- path: "packages/core/**"
instructions: >
This is the core CV evaluation/builder logic. Prioritize correctness of

@amirbahador-hub amirbahador-hub Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core is orchestrator, the logic is everywhere in intelligence, ingestions, server, frontend, prompts and so on

rules, evaluator scoring, and types. Flag changes to public APIs in
src/index.ts and anything in src/types.ts that could break consumers.
New rules/archetypes/evaluator behavior should have matching vitest tests.
- path: "packages/cli/**"
instructions: >
CLI for the CV builder. Watch for unhandled errors, confusing output,

@amirbahador-hub amirbahador-hub Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match with our cli, because our cli is not traditional cli it's prompt as code, it uses users code agents to do this

and missing input validation. Behavior changes should be covered by tests.
- path: "packages/web/**"
instructions: >
Web frontend. Check accessibility, error/loading states, and that UI
stays consistent with the core package's data model.
- path: "**/*.md"
instructions: >
Docs for an open-source project. Check clarity and that setup/commands

@amirbahador-hub amirbahador-hub Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No a lot of them are the prompts templates not the Docs

match the actual scripts in package.json.
tools:
eslint:
enabled: true
markdownlint:
enabled: true
Comment on lines +41 to +45

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify that ESLint and markdownlint configuration files exist

echo "=== ESLint config ==="
fd -t f -d 2 '\.eslintrc\.(js|cjs|json|yaml|yml)$|eslint\.config\.(js|mjs|cjs)$' . || echo "No .eslintrc.* or eslint.config.* found"
rg -l '"eslintConfig"' package.json || echo "No eslintConfig in package.json"

echo "=== markdownlint config ==="
fd -t f -d 2 '\.markdownlint\.(json|yaml|yml|cjs|mjs)$|\.markdownlintrc$' . || echo "No .markdownlint config found"

Repository: TechImmigrants/cv-builder

Length of output: 151

Ensure ESLint/markdownlint configs exist in the repo when enabling them in .coderabbit.yaml.

.coderabbit.yaml enables eslint and markdownlint, but package.json contains no eslintConfig. Add or confirm the repo-level ESLint config (.eslintrc.* or eslint.config.*) and markdownlint config (.markdownlintrc* / markdownlint settings) so CodeRabbit can run both tools correctly.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.coderabbit.yaml around lines 41 - 45, The repo enables eslint and
markdownlint in .coderabbit.yaml but lacks repository-level configurations; add
or confirm ESLint config (e.g., create an .eslintrc.* or eslint.config.* file or
add an "eslintConfig" section to package.json) and add a markdownlint config
(e.g., .markdownlintrc, .markdownlint.json or markdownlint settings in
package.json) so the tools referenced under tools: eslint and markdownlint can
run; ensure the config files are committed to the repo root and include any
required plugins or rules referenced by your codebase.


chat:
auto_reply: true

knowledge_base:
learnings:
scope: auto
Loading