refactor: line length & video attach#787
Open
2278535805 wants to merge 11 commits into
Open
Conversation
Closed
2278535805
changed the title
Contributor
Author
|
Mivik
reviewed
Jun 3, 2026
| parse( | ||
| r, | ||
| &e.scale_x_events, | ||
| factor |
Contributor
Author
There was a problem hiding this comment.
已确认在rpe.rs中缩放判定线会导致video attach无法获取到原始缩放，所以当贴图名称为line.png时rpe.rs不缩放，在game.rs对RPE谱调整判定线长度
Contributor
Author
There was a problem hiding this comment.
原先的判定线缩放0.5也不准确，RPE的判定线长度实际为4000.0 / RPE_WIDTH
This reverts commit c042019.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复判定线分别在不同谱面格式下的长度和宽度
正确显示pgr判定线长度与宽度，正确显示RPE判定线长度，修复rpe.extended为空时的长度