游戏功能更新1 - 收藏夹功能 || Function Update cp1 - Favorites by Navinatte · Pull Request #662 · TeamFlos/phira

Navinatte · 2026-02-23T16:17:30Z

Pr内容包含

收藏夹功能

新增一个收藏夹的页面，初始包含“默认收藏夹”以及“显示全部谱面”，并支持自定义收藏夹以及自定义收藏夹的封面（无自定义封面则默认使用最新收藏的谱面曲绘）

其它内容

按照YuevUwU的建议，保留除简体/繁体中文、英文之外的本地化ai辅助翻译，在开头添加 “#”

代码已经过验证

联系方式（注意需要的话备注来意因为我不认识会拒绝）
QQ: 212898630
邮箱：212898630@qq.com || 212898630fan@gmail.com

Copilot

Pull request overview

This PR adds a new “Favorites / 收藏夹” feature to the Phira client, including folder-based favorites management and UI integration in both the song detail scene and the local library page.

Changes:

Introduces a new Favorites page with default + custom folders, plus custom cover support.
Adds a star toggle button on the song scene (short press toggles default favorites; long press opens folder selection).
Extends local library filtering to show all charts or only charts from a selected favorites folder, with supporting data persistence and localization updates.

Reviewed changes

Copilot reviewed 34 out of 36 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`phira/src/scene/song.rs`	Adds favorites star button + popup folder selector in song scene.
`phira/src/page/library.rs`	Adds favorites filter button and filtering logic for local charts.
`phira/src/page/favorites.rs`	New Favorites management page (folders, covers, rename/delete).
`phira/src/page.rs`	Exposes the new `favorites` module and re-exports `FavoritesPage`.
`phira/src/icons.rs`	Adds `starred` icon texture loading.
`phira/src/data.rs`	Adds persisted `Favorites` structure and related helper APIs.
`phira/locales/*/(song	library).ftl`
`assets/starred.png`	Adds starred icon asset.
`.gitignore`	Adds ignores for several local/dev directories.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-23T16:23:38Z

+    fn enter(&mut self, _s: &mut SharedState) -> Result<()> {
+        Ok(())
+    }


Page::enter already has a default no-op implementation; this override just returns Ok(()) and adds noise. Please remove this method unless you plan to add enter-time logic here.

Copilot · 2026-02-23T16:23:39Z

+            let fav_folder = self.current_fav_folder.clone();
            let mut charts = Vec::new();
-            charts.push(ChartDisplayItem::new(None, None));
+            if fav_folder.is_none() {
+                charts.push(ChartDisplayItem::new(None, None));
+            }
+            let fav_paths: Option<Vec<String>> = fav_folder.as_ref().map(|folder| {
+                get_data().favorites.get_paths(folder)
+            });
            charts.append(
                &mut s
                    .charts_local
                    .iter()
-                    .filter(|it| it.info.name.contains(&search))
+                    .filter(|it| {
+                        let name_match = it.info.name.contains(&search);
+                        let fav_match = match &fav_paths {
+                            Some(paths) => it.local_path.as_ref().map_or(false, |p| paths.contains(p)),
+                            None => true,
+                        };
+                        name_match && fav_match
+                    })


Local favorites filtering does repeated linear Vec::contains checks (and clones the folder path list) for every chart, which can become O(charts × favorites) and noticeably slow for large libraries. Consider turning the folder paths into a HashSet once (or adding an API that returns a borrowed slice / iterator) and then do O(1) membership checks while filtering.

Copilot · 2026-02-23T16:23:39Z

+                                let all_names = get_data().favorites.all_folder_names();
+                                let local_path = self.local_path.as_ref().unwrap();
+                                let options: Vec<String> = all_names
+                                    .iter()
+                                    .map(|name| {
+                                        let display = if name == DEFAULT_FAVORITES_KEY {
+                                            tl!("fav-default-folder").to_string()
+                                        } else {
+                                            name.clone()
+                                        };
+                                        let in_folder = get_data().favorites.get_paths(name).contains(&local_path.to_string());
+                                        if in_folder {
+                                            format!("\u{2713} {display}")
+                                        } else {
+                                            format!("  {display}")
+                                        }
+                                    })


Building the favorites popup options repeatedly clones favorites path lists and allocates new Strings (local_path.to_string()) just for contains checks. This is avoidable overhead in a hot UI path; prefer checking membership without cloning (e.g., iterate/borrow the stored Vec<String> and compare against &String / &str).

Copilot · 2026-02-23T16:23:40Z

+    pub fn is_in_default(&self, local_path: &str) -> bool {
+        self.folders
+            .get(DEFAULT_FAVORITES_KEY)
+            .map_or(false, |v| v.contains(&local_path.to_string()))
+    }
+
+    pub fn is_favorited(&self, local_path: &str) -> bool {
+        self.folders.values().any(|v| v.contains(&local_path.to_string()))
+    }
+
+    pub fn add_to(&mut self, folder: &str, local_path: &str) {
+        let list = self.folders.entry(folder.to_string()).or_default();
+        if !list.contains(&local_path.to_string()) {
+            list.push(local_path.to_string());
+        }


Favorites membership helpers allocate Strings on every call (e.g., v.contains(&local_path.to_string()) / list.contains(&local_path.to_string())). This creates unnecessary allocations; prefer v.iter().any(|p| p == local_path) (or similar) to compare against &str without allocating.

Copilot · 2026-02-23T16:23:40Z

+                        if let Some(ref name) = folder.folder_name {
+                            let count = get_data().favorites.get_paths(name).len();
+                            ui.text(format!("{}", count))
+                                .pos(r.right() - 0.02, r.y + 0.02)
+                                .anchor(1., 0.)
+                                .size(0.35)
+                                .color(semi_white(0.6))
+                                .draw();
+                        }


Rendering the per-folder chart count calls get_paths(name).len(), which currently clones the entire Vec<String> just to get its length. Consider adding a non-cloning accessor (e.g., folder_len) or returning a borrowed slice so this doesn’t allocate every frame.

Copilot · 2026-02-23T16:23:40Z

+                .buttons(vec![
+                    tl!("favorites-all").to_string(),
+                    tl!("favorites-delete").to_string(),
+                ])


In the delete confirmation dialog, the first button label uses tl!("favorites-all") ("All") as the cancel option. This is confusing UX and doesn’t match the dialog intent; please use a proper cancel/back label (existing generic cancel key if available) and keep favorites-all for the “show all” filter only.

Copilot · 2026-02-23T16:23:41Z

+    data::DEFAULT_FAVORITES_KEY,
+    get_data, get_data_mut,
    icons::Icons,
+    page::favorites::FAV_PAGE_RESULT,
    popup::Popup,
    rate::RateDialog,
+    save_data,
    scene::{check_read_tos_and_policy, ChartOrder, JUST_LOADED_TOS, ORDERS},


get_data_mut and save_data are imported but not used in this file. Please remove unused imports to avoid warnings and keep the import list accurate.

Mivik · 2026-03-02T03:30:54Z

Closed in favor of https://github.com/TeamFlos/phira/tree/favorites

Copilot AI review requested due to automatic review settings February 23, 2026 16:17

Copilot started reviewing on behalf of Navinatte February 23, 2026 16:18 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

Navinatte added 3 commits February 25, 2026 15:03

完整的收藏夹功能更新 + 部分本地化（除简体/繁体中文、英文之外其余均为占位符）

235b675

本地化

e475133

恢复 is_default_folder/is_editable 方法及 enter() 方法（重写遗漏的部分）

43aa33a

Navinatte force-pushed the Favorites branch from b5a9d1e to 43aa33a Compare February 25, 2026 07:03

Navinatte and others added 4 commits February 25, 2026 17:07

移除不必要的ignore

5fbe132

chore: Merge branch 'main' into Favorites

17fc013

chore: clippy & fmt

e2e42d6

fix: 修复 clippy 警告（移除死代码、重构 is_some+unwrap、map_or 换 is_some_and）

d141e97

Mivik closed this Mar 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

游戏功能更新1 - 收藏夹功能 || Function Update cp1 - Favorites#662

游戏功能更新1 - 收藏夹功能 || Function Update cp1 - Favorites#662
Navinatte wants to merge 7 commits into
TeamFlos:mainfrom
Navinatte:Favorites

Navinatte commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Copilot AI Feb 23, 2026

Uh oh!

Mivik commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Navinatte commented Feb 23, 2026

收藏夹功能

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Mivik commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants