fix: use dummy backend when no output device is availible#622
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a fallback mechanism to gracefully handle scenarios where no audio output device is available. When audio backend initialization fails, the application now displays an error message and falls back to a dummy backend that silently ignores all audio operations, allowing the application to continue running without sound.
Key changes:
- Added error handling in
build_audio()to catch backend initialization failures and use a dummy backend as fallback - Implemented a minimal
DummyBackendthat satisfies theBackendtrait interface without performing any actual audio operations - Added localized error messages in English and Chinese to inform users when running in silent mode
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| prpr/src/ui.rs | Added error handling for audio backend initialization, implemented DummyBackend struct, and added l10n macro import for translation strings |
| prpr/locales/en-US/scene.ftl | Added English error message for audio backend initialization failure |
| prpr/locales/zh-CN/scene.ftl | Added Chinese error message for audio backend initialization failure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #605 .
Testing steps: disable all your audio devices in your system settings, then run phira.
Things to be discussed: Should the translation string be put into a seprate file, rather than
scene.ftl?