Skip to content

refactor: Fullscreen handling#619

Merged
Mivik merged 2 commits into
TeamFlos:mainfrom
fhscey:main
Mar 2, 2026
Merged

refactor: Fullscreen handling#619
Mivik merged 2 commits into
TeamFlos:mainfrom
fhscey:main

Conversation

@fhscey

@fhscey fhscey commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

This commit refactors fullscreen mode activation to be triggered only once upon user request and extends fullscreen support to Linux.

This commit refactors fullscreen mode activation to be triggered only once upon user request and extends fullscreen support to Linux.

@liquidhelium liquidhelium left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows. It worked fine.

@YuevUwU

YuevUwU commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

Consider to add translation for en-US (for macro fallback_langid), or this message waterfall will be still existing (in both Linux and Windows)

2025-12-31T11:05:20.261179200Z  WARN prpr_l10n::local: no translation found for item-fullscreen, returning key
2025-12-31T11:05:20.261522300Z  WARN prpr_l10n::local: no translation found for item-fullscreen-sub, returning key

@YuevUwU

YuevUwU commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

[BUG]
The Linux build can't expectedly cancel the fullscreen mode.
Disable fullscreen_mode will flash and still in fullscreen mode.
Tested on VirtualBox VM with these OS:

  • Linux Mint 22.1 x86_64 + Xfce4 4.18 + Xfwm4 (X11)
  • Fedora Linux 43 (Workstation Edition) x86_64 + GNOME 49.2 + Mutter (Wayland)

Current Behaviour of Implementation on Windows (Record-only, not bug or expected behaviour)

  • Game does not enter fullscreen based on current config.fullscreen_mode setting
    • Reproduction: Exit fullscreen mode using Alt-F4, then re-enter the game
  • If make window maximize, and enable fullscreen, and disable fullscreen, it will go back to window mode but not maximized

@Mivik

Mivik commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

LGTM, thanks!

@Mivik
Mivik merged commit 646b354 into TeamFlos:main Mar 2, 2026
3 checks passed
@YuevUwU

YuevUwU commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Linux Fullscreen Cancellation issue should be fixed since
Mivik/prpr-miniquad@3dfb072
Mivik/prpr-macroquad@0f2c9d8 (dep lock)
Phira: 749cbb7 (dep lock)

-- Tested on Linux Mint (X11) and Fedora (Wayland), with latest commit: 8467425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants